Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 4870bb530276458e775f39deb9f75915a94af7ba
https://github.com/openSUSE/open-build-service/commit/4870bb530276458e775f39...
Author: Eduardo Navarro
Date: 2023-09-25 (Mon, 25 Sep 2023)
Changed paths:
M src/api/app/components/report_component.html.haml
M src/api/app/components/report_component.rb
Log Message:
-----------
Remove unused `modal_title` attribute
The title of the modal is already set by javascript.
Commit: 9ee4a5354fc6a7c00207b483c578475153ec3ced
https://github.com/openSUSE/open-build-service/commit/9ee4a5354fc6a7c00207b4...
Author: Eduardo Navarro
Date: 2023-09-25 (Mon, 25 Sep 2023)
Changed paths:
M src/api/app/components/bs_request_comment_component.html.haml
M src/api/app/components/report_component.html.haml
M src/api/app/components/report_component.rb
M src/api/app/controllers/webui/reports_controller.rb
M src/api/app/views/webui/comment/_reply.html.haml
M src/api/app/views/webui/comment/_show.html.haml
M src/api/app/views/webui/package/show.html.haml
M src/api/app/views/webui/package/show_actions/_report_package.html.haml
M src/api/app/views/webui/project/show.html.haml
M src/api/app/views/webui/project/show_actions/_report_project.html.haml
M src/api/app/views/webui/reports/create.js.erb
M src/api/app/views/webui/request/beta_show.html.haml
M src/api/app/views/webui/user/_basic_info.html.haml
Log Message:
-----------
Remove `modal_id` in Report Component
It is enough to have one report modal in each rendered page.
Commit: bd68a6f27b2eb893b2ffee5f677bd50dba5dc745
https://github.com/openSUSE/open-build-service/commit/bd68a6f27b2eb893b2ffee...
Author: Eduardo Navarro
Date: 2023-09-25 (Mon, 25 Sep 2023)
Changed paths:
M src/api/app/assets/javascripts/webui/report.js
M src/api/app/components/report_component.html.haml
M src/api/app/components/report_component.rb
M src/api/app/views/webui/comment/_show.html.haml
M src/api/app/views/webui/package/show.html.haml
M src/api/app/views/webui/project/show.html.haml
M src/api/app/views/webui/request/beta_show.html.haml
M src/api/app/views/webui/user/_basic_info.html.haml
Log Message:
-----------
Set the confirmation text from the link
In the same web page there could be several links which could open the
report modal for different type of objects. Setting the confirmation
text from the component isn't the solution.
Commit: a028e42c8f918bd9af20817b184a0627024d54af
https://github.com/openSUSE/open-build-service/commit/a028e42c8f918bd9af2081...
Author: Eduardo Navarro
Date: 2023-09-25 (Mon, 25 Sep 2023)
Changed paths:
M src/api/app/components/report_component.rb
M src/api/app/views/webui/comment/_show.html.haml
M src/api/app/views/webui/package/show.html.haml
M src/api/app/views/webui/project/show.html.haml
M src/api/app/views/webui/request/beta_show.html.haml
M src/api/app/views/webui/user/_basic_info.html.haml
Log Message:
-----------
Move policy checks inside ReportComponent
Pass `reportable` parameter to ReportComponent. This way we can check
the policies inside the Report component.
Also, get rid of the `user` parameter. This was used only to check for
the content_moderation feature flag. But this is already done in the
policy check for the Report model.
Commit: ff30e4ebca83034b94bff05d714c65b74955a99c
https://github.com/openSUSE/open-build-service/commit/ff30e4ebca83034b94bff0...
Author: Eduardo Navarro
Date: 2023-09-25 (Mon, 25 Sep 2023)
Changed paths:
M src/api/app/views/webui/comment/_show.html.haml
M src/api/app/views/webui/request/_request_comments.html.haml
Log Message:
-----------
Move Report component call outside the comment list
Project, package and request pages use the comment list. The project and
package pages already call the Report component. The request view didn't.
Call the Report component from the `request/_request_comments partial`,
so we can get rid of the call of the Report component in the
`comment/_show` partial, wich is redundant for projects and packages.
Commit: bac53b8d52ba8e5b0a897dd9eb04e7eb06f92c45
https://github.com/openSUSE/open-build-service/commit/bac53b8d52ba8e5b0a897d...
Author: Lukas Krause
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M src/api/app/assets/javascripts/webui/report.js
M src/api/app/components/report_component.rb
Log Message:
-----------
Fix javascript and remove render condition from report modal
We cannot authorize inside the render condition in this case.
We render the modal on the package, project and request views,
then set the attributes on the form inside the model via
javascript. When for example we cannot report on the package itself
but on the comment that is on the package view, the component
is not rendered. We already have authorization on the controller
code and the report links. There is no need to do this on the modal.
Commit: 2547088f9876dfade89590920cf767ad0674ae65
https://github.com/openSUSE/open-build-service/commit/2547088f9876dfade89590...
Author: Lukas Krause
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
R src/api/app/components/report_component.html.haml
R src/api/app/components/report_component.rb
M src/api/app/views/webui/package/show.html.haml
M src/api/app/views/webui/project/show.html.haml
M src/api/app/views/webui/request/_request_comments.html.haml
M src/api/app/views/webui/request/beta_show.html.haml
A src/api/app/views/webui/shared/_report_modal.html.haml
M src/api/app/views/webui/user/_basic_info.html.haml
Log Message:
-----------
Move report component to a partial
After removing the render? condition from the component,
there is nothing left where a view component would be beneficial.
All attributes are set via javascript. Lets move it to a partial.
Commit: 21ba858d147c802027e28ebef4deb704578ed1ca
https://github.com/openSUSE/open-build-service/commit/21ba858d147c802027e28e...
Author: Jacob Michalskie
Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths:
M src/api/app/assets/javascripts/webui/report.js
M src/api/app/components/bs_request_comment_component.html.haml
R src/api/app/components/report_component.html.haml
R src/api/app/components/report_component.rb
M src/api/app/controllers/webui/reports_controller.rb
M src/api/app/views/webui/comment/_reply.html.haml
M src/api/app/views/webui/comment/_show.html.haml
M src/api/app/views/webui/package/show.html.haml
M src/api/app/views/webui/package/show_actions/_report_package.html.haml
M src/api/app/views/webui/project/show.html.haml
M src/api/app/views/webui/project/show_actions/_report_project.html.haml
M src/api/app/views/webui/reports/create.js.erb
M src/api/app/views/webui/request/_request_comments.html.haml
M src/api/app/views/webui/request/beta_show.html.haml
A src/api/app/views/webui/shared/_report_modal.html.haml
M src/api/app/views/webui/user/_basic_info.html.haml
Log Message:
-----------
Merge pull request #14935 from eduardoj/refactoring/report_component
Refactor report component
Compare: https://github.com/openSUSE/open-build-service/compare/dbbf111efbc1...21ba85...
