April 2021 - Open Build Service Commits

[openSUSE/open-build-service]
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] a1eb7a: Refactor code for tokens
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: a1eb7a46b270271592ac4ee53127184b840ae92c https://github.com/openSUSE/open-build-service/commit/a1eb7a46b270271592ac4… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: R src/api/app/controllers/services/webhooks_controller.rb M src/api/app/controllers/trigger/errors.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token.rb A src/api/app/models/token/errors.rb M src/api/app/models/token/rebuild.rb M src/api/app/models/token/release.rb M src/api/app/models/token/service.rb A src/api/app/policies/token/rebuild_policy.rb A src/api/app/policies/token/release_policy.rb A src/api/app/policies/token/service_policy.rb M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/config/routes/api_routes.rb R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_3_1_1_1.yml R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_2_1_1_1.yml R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_1_1_1_1.yml A src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_1.yml A src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_2.yml A src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml A src/api/spec/cassettes/Token_Release/_call/when_no_manual_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/Token_Release/_call/when_no_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml M src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_1_1_1.yml A src/api/spec/cassettes/TriggerController/_rebuild/when_project_passed_by_params_ignore_it/1_1_3_1.yml M src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid_and_packet_rebuild/1_1_2_1.yml A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml R src/api/spec/controllers/services/webhooks_controller_spec.rb M src/api/spec/controllers/trigger_controller_spec.rb M src/api/spec/factories/tokens.rb A src/api/spec/models/token/release_spec.rb R src/api/spec/models/token/service_spec.rb A src/api/spec/models/token_spec.rb A src/api/spec/policies/token/rebuild_policy_spec.rb A src/api/spec/policies/token/release_policy_spec.rb A src/api/spec/policies/token/service_policy_spec.rb M src/api/spec/services/trigger_controller_service/token_extractor_spec.rb A src/api/spec/support/shared_examples/tokens.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Refactor code for tokens Result of multiple mob programming sessions to lay out foundations to a better SCM/CI integration. The controllers trigger_controller and services/webhooks_controller are now merged and a single action is handling the various tokens. The routes are kept for backward compatibility. Authorization is done through Pundit, although we couldn't get away from Package.get_by_project_and_name... it's just doing too much and we wanted to avoid increasing the scope of the changes even more. Anything related to extracting tokens out of the various headers/parameters is now handled by TriggerControllerService::TokenExtractor. It was previously scattered in the aforementioned controllers and token models. Finally, the specs were adapted to follow the changes. Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Co-authored-by: Henne Vogelsang <hvogel(a)opensuse.org> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Co-authored-by: Victor Pereira <vpereira(a)suse.com>

1 0

[openSUSE/open-build-service] b0257b: Refactor code for tokens
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: b0257b4d46e3c178440aadb4e1d8d9a8e27ffcef https://github.com/openSUSE/open-build-service/commit/b0257b4d46e3c178440aa… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: R src/api/app/controllers/services/webhooks_controller.rb M src/api/app/controllers/trigger/errors.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token.rb A src/api/app/models/token/errors.rb M src/api/app/models/token/rebuild.rb M src/api/app/models/token/release.rb M src/api/app/models/token/service.rb A src/api/app/policies/token/rebuild_policy.rb A src/api/app/policies/token/release_policy.rb A src/api/app/policies/token/service_policy.rb M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/config/routes/api_routes.rb R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_3_1_1_1.yml R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_2_1_1_1.yml R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_1_1_1_1.yml A src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_1.yml A src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_2.yml A src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml A src/api/spec/cassettes/Token_Release/_call/when_no_manual_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/Token_Release/_call/when_no_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml M src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_1_1_1.yml M src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid_and_packet_rebuild/1_1_2_1.yml A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml R src/api/spec/controllers/services/webhooks_controller_spec.rb M src/api/spec/controllers/trigger_controller_spec.rb M src/api/spec/factories/tokens.rb A src/api/spec/models/token/release_spec.rb R src/api/spec/models/token/service_spec.rb A src/api/spec/models/token_spec.rb A src/api/spec/policies/token/rebuild_policy_spec.rb A src/api/spec/policies/token/release_policy_spec.rb A src/api/spec/policies/token/service_policy_spec.rb M src/api/spec/services/trigger_controller_service/token_extractor_spec.rb A src/api/spec/support/shared_examples/tokens.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Refactor code for tokens Result of multiple mob programming sessions to lay out foundations to a better SCM/CI integration. The controllers trigger_controller and services/webhooks_controller are now merged and a single action is handling the various tokens. The routes are kept for backward compatibility. Authorization is done through Pundit, although we couldn't get away from Package.get_by_project_and_name... it's just doing too much and we wanted to avoid increasing the scope of the changes even more. Anything related to extracting tokens out of the various headers/parameters is now handled by TriggerControllerService::TokenExtractor. It was previously scattered in the aforementioned controllers and token models. Finally, the specs were adapted to follow the changes. Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Co-authored-by: Henne Vogelsang <hvogel(a)opensuse.org> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Co-authored-by: Victor Pereira <vpereira(a)suse.com>

1 0

[openSUSE/open-build-service] b93533: Refactor code for tokens
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: b93533779759ae17c68f1cb91eeb6a0960d44bfe https://github.com/openSUSE/open-build-service/commit/b93533779759ae17c68f1… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: R src/api/app/controllers/services/webhooks_controller.rb M src/api/app/controllers/trigger/errors.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token.rb A src/api/app/models/token/errors.rb M src/api/app/models/token/rebuild.rb M src/api/app/models/token/release.rb M src/api/app/models/token/service.rb A src/api/app/policies/token/rebuild_policy.rb A src/api/app/policies/token/release_policy.rb A src/api/app/policies/token/service_policy.rb M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/config/routes/api_routes.rb R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_3_1_1_1.yml R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_2_1_1_1.yml R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_1_1_1_1.yml A src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_1.yml A src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_2.yml A src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml A src/api/spec/cassettes/Token_Release/_call/when_no_manual_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/Token_Release/_call/when_no_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml M src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_1_1_1.yml M src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid_and_packet_rebuild/1_1_2_1.yml A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml R src/api/spec/controllers/services/webhooks_controller_spec.rb M src/api/spec/controllers/trigger_controller_spec.rb M src/api/spec/factories/tokens.rb A src/api/spec/models/token/release_spec.rb R src/api/spec/models/token/service_spec.rb A src/api/spec/models/token_spec.rb A src/api/spec/policies/token/rebuild_policy_spec.rb A src/api/spec/policies/token/release_policy_spec.rb A src/api/spec/policies/token/service_policy_spec.rb M src/api/spec/services/trigger_controller_service/token_extractor_spec.rb A src/api/spec/support/shared_examples/tokens.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Refactor code for tokens Result of multiple mob programming sessions to lay out foundations to a better SCM/CI integration. The controllers trigger_controller and services/webhooks_controller are now merged and a single action is handling the various tokens. The routes are kept for backward compatibility. Authorization is done through Pundit, although we couldn't get away from Package.get_by_project_and_name... it's just doing too much and we wanted to avoid increasing the scope of the changes even more. Anything related to extracting tokens out of the various headers/parameters is now handled by TriggerControllerService::TokenExtractor. It was previously scattered in the aforementioned controllers and token models. Finally, the specs were adapted to follow the changes. Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Co-authored-by: Henne Vogelsang <hvogel(a)opensuse.org> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Co-authored-by: Victor Pereira <vpereira(a)suse.com>

1 0

[openSUSE/open-build-service] e046fc: Rename _params to _options in Token
by Dany Marcoux 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: e046fcbfa47cef78d2311fb79b376d4037b74277 https://github.com/openSUSE/open-build-service/commit/e046fcbfa47cef78d2311… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/models/token.rb Log Message: ----------- Rename _params to _options in Token

1 0

[openSUSE/open-build-service] d7534d: WIP initial commit
by Dany Marcoux 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: d7534d1b20b1501f4cbdc3aa804e3ba00daa715a https://github.com/openSUSE/open-build-service/commit/d7534d1b20b1501f4cbdc… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- WIP initial commit Commit: 4e325a1779df778732bd586d4c9dc4f7ec0a9374 https://github.com/openSUSE/open-build-service/commit/4e325a1779df778732bd5… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/config/routes/api_routes.rb A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Change route and update cassetes Commit: 668df824128fe7ff1b9273f7a64c6e1353610acc https://github.com/openSUSE/open-build-service/commit/668df824128fe7ff1b927… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token/rebuild.rb M src/api/app/models/token/release.rb M src/api/app/models/token/service.rb M src/api/app/services/trigger_controller_service/token_extractor.rb Log Message: ----------- Reorganize code Commit: 8493fcbe87f230c467a1b0c6caa2a2cfafc126d4 https://github.com/openSUSE/open-build-service/commit/8493fcbe87f230c467a1b… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token.rb M src/api/app/models/token/rebuild.rb Log Message: ----------- Further refactoring Commit: 249fdb6e253c71c588be8df273c5b6dca9d0affb https://github.com/openSUSE/open-build-service/commit/249fdb6e253c71c588be8… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token.rb M src/api/app/models/token/rebuild.rb M src/api/app/models/token/release.rb M src/api/app/models/token/service.rb M src/api/app/services/trigger_controller_service/token_extractor.rb Log Message: ----------- the road to the success is under construction Commit: fb011433815407cdbfc9a628476699cdfd2cf2df https://github.com/openSUSE/open-build-service/commit/fb011433815407cdbfc9a… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/models/token/rebuild.rb Log Message: ----------- WIP: Refactor package.rebuild Commit: 3f809863bdd3d03b75aab68485d50de2073f5353 https://github.com/openSUSE/open-build-service/commit/3f809863bdd3d03b75aab… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/models/package.rb M src/api/app/models/token/rebuild.rb A src/api/app/policies/token/rebuild_policy.rb Log Message: ----------- WIP: rebuild refactoring Commit: 026b69952c298f5f29774e0caff0cba321a0d22b https://github.com/openSUSE/open-build-service/commit/026b69952c298f5f29774… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token.rb M src/api/app/models/token/rebuild.rb M src/api/app/models/token/release.rb M src/api/app/models/token/service.rb M src/api/app/policies/token/rebuild_policy.rb A src/api/app/policies/token/release_policy.rb A src/api/app/policies/token/service_policy.rb M src/api/app/services/trigger_controller_service/token_extractor.rb Log Message: ----------- Authorization Commit: 1e94668bdfea4be6839dd6c9e8c7052f9d894c33 https://github.com/openSUSE/open-build-service/commit/1e94668bdfea4be6839dd… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token/service.rb M src/api/app/policies/package_policy.rb M src/api/app/policies/token/rebuild_policy.rb M src/api/app/policies/token/service_policy.rb M src/api/app/services/package_controller_service/rebuild_trigger.rb Log Message: ----------- Implement rebuild token policy Commit: cff6ab465cc29e350978be9786603f5f6d1dd314 https://github.com/openSUSE/open-build-service/commit/cff6ab465cc29e350978b… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger/errors.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token/release.rb M src/api/app/policies/package_policy.rb M src/api/app/services/package_controller_service/rebuild_trigger.rb M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/config/routes/api_routes.rb Log Message: ----------- Clean up code, define set_package callback and more - Redirect rebuild via routes - Use package_from_association_or_params in TriggerController Commit: c3a40dbab4f44293d0b29d07aa32671802882575 https://github.com/openSUSE/open-build-service/commit/c3a40dbab4f44293d0b29… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token/rebuild.rb M src/api/app/models/token/release.rb M src/api/app/policies/token/release_policy.rb M src/api/config/routes/api_routes.rb Log Message: ----------- Finish rebuild and release implementation Commit: c890242ef0a48fc8346ecf8c2e625d9179af28e4 https://github.com/openSUSE/open-build-service/commit/c890242ef0a48fc8346ec… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- WIP Fix trigger controller specs Commit: fa9ad645fde802710e0d9b1fa79d45ead87e41a6 https://github.com/openSUSE/open-build-service/commit/fa9ad645fde802710e0d9… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger/errors.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/models/token/rebuild.rb M src/api/app/models/token/release.rb M src/api/app/models/token/service.rb M src/api/config/routes/api_routes.rb Log Message: ----------- Tackle TODOs Commit: f0d4febcd32b12b286de3ac54c3cca317f3082db https://github.com/openSUSE/open-build-service/commit/f0d4febcd32b12b286de3… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: R src/api/app/controllers/services/webhooks_controller.rb M src/api/app/models/package.rb M src/api/app/models/token/rebuild.rb M src/api/app/services/package_controller_service/rebuild_trigger.rb M src/api/app/services/trigger_controller_service/token_extractor.rb R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_3_1_1_1.yml R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_2_1_1_1.yml R src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_1_1_1_1.yml R src/api/spec/controllers/services/webhooks_controller_spec.rb Log Message: ----------- Delete more unneeded files Commit: 1d97e4a3fab6eb679bbe4b64a9ecfcc067f1b7e6 https://github.com/openSUSE/open-build-service/commit/1d97e4a3fab6eb679bbe4… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/factories/tokens.rb A src/api/spec/policies/token/rebuild_policy_spec.rb Log Message: ----------- First commit about rebuild token policy Commit: ec6086e880dbf6b29401d4b0b080b4cf44d51be7 https://github.com/openSUSE/open-build-service/commit/ec6086e880dbf6b29401d… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_1.yml A src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_2.yml Log Message: ----------- Cassetes for TokenRebuild Commit: 85b41eeea326fdbb5dc7c2f04ce8c2ad4677d437 https://github.com/openSUSE/open-build-service/commit/85b41eeea326fdbb5dc7c… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/models/token/release.rb Log Message: ----------- Fix linter for release Commit: e81cdc551fffc098a102aec1af256f701e9edd5f https://github.com/openSUSE/open-build-service/commit/e81cdc551fffc098a102a… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_1.yml M src/api/spec/cassettes/Token_RebuildPolicy/_create/create_/1_1_1_2.yml M src/api/spec/factories/tokens.rb M src/api/spec/policies/token/rebuild_policy_spec.rb A src/api/spec/policies/token/release_policy_spec.rb Log Message: ----------- Submit specs for Token Rebuild and Release policies Delete the unecessary VCR files (to test the policy we don't need the backend) Commit: 358fcfbe7cd36bbe3173d486d2c90029097e323b https://github.com/openSUSE/open-build-service/commit/358fcfbe7cd36bbe3173d… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Disable locally the rubocop to make circleci green Commit: 6a7d4a89a260ab5bf1c2a3e9485d5452038c1b00 https://github.com/openSUSE/open-build-service/commit/6a7d4a89a260ab5bf1c2a… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger/errors.rb M src/api/app/models/token.rb A src/api/app/models/token/errors.rb M src/api/app/models/token/release.rb Log Message: ----------- Fix exception class handling for release token model The location of the exception class definition was wrong and therefore an uninitialized constant error was thrown by the release token model. The naming of the exception class did not quite fit as well. Commit: 5b8cb309a935fa6067ba1496e2a771129aa02953 https://github.com/openSUSE/open-build-service/commit/5b8cb309a935fa6067ba1… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/factories/tokens.rb A src/api/spec/policies/token/service_policy_spec.rb Log Message: ----------- Add service policies spec Commit: 89ed8bf9ddd4d2abfd4c770c496ee10e7fae24f5 https://github.com/openSUSE/open-build-service/commit/89ed8bf9ddd4d2abfd4c7… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/policies/token/rebuild_policy_spec.rb M src/api/spec/policies/token/release_policy_spec.rb M src/api/spec/policies/token/service_policy_spec.rb A src/api/spec/support/shared_examples/tokens.rb Log Message: ----------- Refactor Token policies to use shared examples Commit: 7f368599196241886fb1fd03c4d965fa7cc9d6c7 https://github.com/openSUSE/open-build-service/commit/7f368599196241886fb1f… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Fixes `#rebuild` trigger controller spec failures Commit: 7dca4d5d6b5d6941a3d7c576af0f8551b1208019 https://github.com/openSUSE/open-build-service/commit/7dca4d5d6b5d6941a3d7c… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/models/token.rb Log Message: ----------- Add uniqueness validation for token string On the database level we already ensure the uniqueness of the token string through an uniq index. In order to properly test this in the model specs and to have better exception handling, the validation should also be present in the token model. Commit: 10fd3467a693e0833c0cde04994249d2f668d07a https://github.com/openSUSE/open-build-service/commit/10fd3467a693e0833c0cd… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Fix trigger controller's `#release` method spec failures Commit: 8ee65ed4f82b76eaad768ee30a9850ac3605a66a https://github.com/openSUSE/open-build-service/commit/8ee65ed4f82b76eaad768… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Fix trigger controller's rebuild method spec failures Commit: e7f4d576c5eab635299c6df29b9ee61013f94702 https://github.com/openSUSE/open-build-service/commit/e7f4d576c5eab635299c6… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/factories/tokens.rb Log Message: ----------- Move associations and trait inside base token factory Commit: 8579cc192197da5f2489f730aba92abb5915a8f9 https://github.com/openSUSE/open-build-service/commit/8579cc192197da5f2489f… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/spec/controllers/trigger_controller_spec.rb M src/api/spec/services/trigger_controller_service/token_extractor_spec.rb Log Message: ----------- Fix TokenExtractor and write specs Commit: 397808d904da5ddab04a0cac43a512abe0581ec7 https://github.com/openSUSE/open-build-service/commit/397808d904da5ddab04a0… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/models/token/service_spec.rb A src/api/spec/models/token_spec.rb Log Message: ----------- Add specs for token base model Commit: 90095079af00a8eff4b3ab644d9888238a37fcf5 https://github.com/openSUSE/open-build-service/commit/90095079af00a8eff4b3a… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: R src/api/spec/models/token/service_spec.rb Log Message: ----------- Remove Token::Service spec It's testing code which was moved to the service TriggerControllerService::TokenExtractor. Commit: 3bb029d856e698089757b2f5bd2235f8e3701051 https://github.com/openSUSE/open-build-service/commit/3bb029d856e698089757b… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml A src/api/spec/cassettes/Token_Release/_call/when_no_manual_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/Token_Release/_call/when_no_release_target_is_set/throws_an_exception.yml A src/api/spec/models/token/release_spec.rb Log Message: ----------- Add specs for release token model Commit: 93d7fc3e628624e8a12410a416823a9f49b81ad2 https://github.com/openSUSE/open-build-service/commit/93d7fc3e628624e8a1241… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/models/token_spec.rb Log Message: ----------- Fix broken validation spec for Token model Commit: 4294b921c89e7a2a646bb1bd5b78aa503948dc2a https://github.com/openSUSE/open-build-service/commit/4294b921c89e7a2a646bb… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml M src/api/spec/models/token/release_spec.rb Log Message: ----------- Fix release token model spec The package in the spec did not had a fixed package name which led to problems with the VCR cassettes. Commit: fa053fc5096742c003e4a124f4de552dd3139ad6 https://github.com/openSUSE/open-build-service/commit/fa053fc5096742c003e4a… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml M src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_1_1_1.yml M src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid_and_packet_rebuild/1_1_2_1.yml A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Fix failing specs from Trigger Controller's `#create` method Commit: 373b48a6f7a236ccaed9eff575bd7d0a55059e71 https://github.com/openSUSE/open-build-service/commit/373b48a6f7a236ccaed9e… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Fix Minitest tests related to trigger_controller Fixes: 1. Instead of raising the error NoPermissionForActive when authorization isn't passing, we're doing it with Pundit now. This explains why the tests had to be changed. 2. `ActionController::UnfilteredParameters: unable to convert unpermitted parameters to hash` was happening since we didn't run permit on the params. Compare: https://github.com/openSUSE/open-build-service/compare/afee6fdf60f0...373b4…

1 0

[openSUSE/open-build-service] 6fcf61: Fix Minitest tests related to trigger_controller
by Lukas Krause 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 6fcf61219557dd3916f4f02849359880e218f799 https://github.com/openSUSE/open-build-service/commit/6fcf61219557dd3916f4f… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Fix Minitest tests related to trigger_controller Fixes: 1. Instead of raising the error NoPermissionForActive when authorization isn't passing, we're doing it with Pundit now. This explains why the tests had to be changed. 2. `ActionController::UnfilteredParameters: unable to convert unpermitted parameters to hash` was happening since we didn't run permit on the params. Commit: afee6fdf60f087d45cfb7a4f7acef525c49dc426 https://github.com/openSUSE/open-build-service/commit/afee6fdf60f087d45cfb7… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Merge pull request #11045 from dmarcoux/refactor_trigger_webhooks_controllers-fix_minitest_tests Fix Minitest tests related to trigger_controller Compare: https://github.com/openSUSE/open-build-service/compare/bdbc3c160a52...afee6…

1 0

[openSUSE/osc] 320add: simpleimage uses OTHER directory to deliver files
by Marcus Hüwe 26 Apr '21

26 Apr '21

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 320adda39904c311c6770d0a172488fabc18454f https://github.com/openSUSE/osc/commit/320adda39904c311c6770d0a172488fabc18… Author: Adrian Schröter <adrian(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M osc/build.py Log Message: ----------- simpleimage uses OTHER directory to deliver files Commit: 64ab6930c5a523fffd957ae7e83b88c34083a4d5 https://github.com/openSUSE/osc/commit/64ab6930c5a523fffd957ae7e83b88c34083… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M osc/build.py Log Message: ----------- Merge branch 'fix-simpleimage' of https://github.com/adrianschroeter/osc Use the correct build result directory in case of a "simpleimage" build (the results are stored in the "OTHER" directory). Compare: https://github.com/openSUSE/osc/compare/dd9130a292cf...64ab6930c5a5

1 0

[openSUSE/open-build-service] 1efedc: Fix failing specs from Trigger Controller's `#crea...
by Dany Marcoux 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 1efedc5531857acc5ef866272cadc194438f1336 https://github.com/openSUSE/open-build-service/commit/1efedc5531857acc5ef86… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml M src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_1_1_1.yml M src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid_and_packet_rebuild/1_1_2_1.yml A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Fix failing specs from Trigger Controller's `#create` method Commit: bdbc3c160a52bdd78537730dc2949c943e64ca0d https://github.com/openSUSE/open-build-service/commit/bdbc3c160a52bdd785377… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_package.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_entity_does_not_exist/renders_an_error_for_project.yml M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_an_inactive_user.yml A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_user_has_no_permissions/renders_an_error_for_missing_package_permissions.yml M src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_1_1_1.yml M src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid_and_packet_rebuild/1_1_2_1.yml A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Merge pull request #11044 from danidoni/fix-trigger-controllers-create-method-failing-specs Fix failing specs from Trigger Controller's `#create` method Compare: https://github.com/openSUSE/open-build-service/compare/6370f24afd38...bdbc3…

1 0

[openSUSE/open-build-service] f796ad: Fix release token model spec
by Dany Marcoux 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: f796ad72e88429c9ef6ac87235b742ea2ad148d9 https://github.com/openSUSE/open-build-service/commit/f796ad72e88429c9ef6ac… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml M src/api/spec/models/token/release_spec.rb Log Message: ----------- Fix release token model spec The package in the spec did not had a fixed package name which led to problems with the VCR cassettes. Commit: 6370f24afd3800d900dd4fad9fb5b124cad61379 https://github.com/openSUSE/open-build-service/commit/6370f24afd3800d900dd4… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml M src/api/spec/models/token/release_spec.rb Log Message: ----------- Merge pull request #11043 from krauselukas/fix_release_token_model_spec Fix release token model spec Compare: https://github.com/openSUSE/open-build-service/compare/4cad624d0b0b...6370f…

1 0

[openSUSE/obs-build] b9fd12: simpleimage: allow to disable built-in tar ball cr...
by Adrian Schröter 26 Apr '21

26 Apr '21

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: b9fd1213bbf3491344884e790d14e6970574a655 https://github.com/openSUSE/obs-build/commit/b9fd1213bbf3491344884e790d14e6… Author: Adrian Schröter <adrian(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M build-recipe-simpleimage Log Message: ----------- simpleimage: allow to disable built-in tar ball creation do not build a tar ball when building a squashfs image to avoid disk space polution allow to bring additional source files (do not remove them).

1 0

[openSUSE/open-build-service] 517bc5: Fix broken validation spec for Token model
by Lukas Krause 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 517bc55112c445863ccbc77d915611a1a9d38da0 https://github.com/openSUSE/open-build-service/commit/517bc55112c445863ccbc… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/models/token_spec.rb Log Message: ----------- Fix broken validation spec for Token model Commit: 4cad624d0b0bb74537522988669feacf7f3f96ee https://github.com/openSUSE/open-build-service/commit/4cad624d0b0bb74537522… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/models/token_spec.rb Log Message: ----------- Merge pull request #11042 from dmarcoux/fix-broken-validation-spec Fix broken validation spec for Token model Compare: https://github.com/openSUSE/open-build-service/compare/4df4bea26115...4cad6…

1 0

[openSUSE/obs-build] 00e492: Rename "FromHost" to "OnlyNative"
by Michael Schroeder 26 Apr '21

26 Apr '21

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 00e4922347728c5607a99665d593a289f427eec3 https://github.com/openSUSE/obs-build/commit/00e4922347728c5607a99665d593a2… Author: Michael Schroeder <mls(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M Build.pm M Build/Rpm.pm M PBuild/Recipe.pm M pbuild Log Message: ----------- Rename "FromHost" to "OnlyNative" Add "AlsoNative" to specify that a package must be installed both in the root and in the sysroot. Add "#!NativeBuild" as new marker that this is to be a native build instead of checking the package name.

1 0

[openSUSE/open-build-service] 8789d2: Add specs for release token model
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 8789d282b980a4ee95dbe16d40d202dca648b87f https://github.com/openSUSE/open-build-service/commit/8789d282b980a4ee95dbe… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml A src/api/spec/cassettes/Token_Release/_call/when_no_manual_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/Token_Release/_call/when_no_release_target_is_set/throws_an_exception.yml A src/api/spec/models/token/release_spec.rb Log Message: ----------- Add specs for release token model Commit: 4df4bea261158244926c93b12a88cf5b955dd1e2 https://github.com/openSUSE/open-build-service/commit/4df4bea261158244926c9… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A src/api/spec/cassettes/Token_Release/_call/when_a_manual_release_target_is_set/triggers_the_release_process_in_the_backend.yml A src/api/spec/cassettes/Token_Release/_call/when_no_manual_release_target_is_set/throws_an_exception.yml A src/api/spec/cassettes/Token_Release/_call/when_no_release_target_is_set/throws_an_exception.yml A src/api/spec/models/token/release_spec.rb Log Message: ----------- Merge pull request #11040 from krauselukas/release_token_model_spec Add specs for release token model Compare: https://github.com/openSUSE/open-build-service/compare/fe9b5c954247...4df4b…

1 0

[openSUSE/open-build-service] 94ba84: Remove Token::Service spec
by Lukas Krause 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 94ba8488c4959a017ba180ff4bf36b1e45c863d2 https://github.com/openSUSE/open-build-service/commit/94ba8488c4959a017ba18… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: R src/api/spec/models/token/service_spec.rb Log Message: ----------- Remove Token::Service spec It's testing code which was moved to the service TriggerControllerService::TokenExtractor. Commit: fe9b5c9542471f8d901cec052a0643023c3939fd https://github.com/openSUSE/open-build-service/commit/fe9b5c9542471f8d901ce… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: R src/api/spec/models/token/service_spec.rb Log Message: ----------- Merge pull request #11041 from dmarcoux/remove_model_token_service_spec Remove Token::Service spec Compare: https://github.com/openSUSE/open-build-service/compare/bbfd7a7c3932...fe9b5…

1 0

[openSUSE/open-build-service] d963cf: Add specs for token base model
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: d963cf8ac0c7a93b30d4cbb7a34d0fbd71e9ea48 https://github.com/openSUSE/open-build-service/commit/d963cf8ac0c7a93b30d4c… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/models/token/service_spec.rb A src/api/spec/models/token_spec.rb Log Message: ----------- Add specs for token base model Commit: bbfd7a7c3932010dcd3dac780d1a803c53302a6a https://github.com/openSUSE/open-build-service/commit/bbfd7a7c3932010dcd3da… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/models/token/service_spec.rb A src/api/spec/models/token_spec.rb Log Message: ----------- Merge pull request #11039 from krauselukas/token_base_model_spec Add specs for token base model Compare: https://github.com/openSUSE/open-build-service/compare/0c9255490c28...bbfd7…

1 0

[openSUSE/open-build-service] 9bb777: Move associations and trait inside base token factory
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 9bb7779512e2c5d3a372b6412f74992c73a92145 https://github.com/openSUSE/open-build-service/commit/9bb7779512e2c5d3a372b… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/factories/tokens.rb Log Message: ----------- Move associations and trait inside base token factory Commit: 49455195b942c26ca79a85db430b80adcf8951b6 https://github.com/openSUSE/open-build-service/commit/49455195b942c26ca79a8… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/spec/controllers/trigger_controller_spec.rb M src/api/spec/services/trigger_controller_service/token_extractor_spec.rb Log Message: ----------- Fix TokenExtractor and write specs Commit: 0c9255490c28a894475156a25e9b0489d99d33da https://github.com/openSUSE/open-build-service/commit/0c9255490c28a89447515… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/spec/controllers/trigger_controller_spec.rb M src/api/spec/factories/tokens.rb M src/api/spec/services/trigger_controller_service/token_extractor_spec.rb Log Message: ----------- Merge pull request #11028 from dmarcoux/refactor_trigger_webhooks_controllers-token_extractor_spec Fix TokenExtractor and write specs Compare: https://github.com/openSUSE/open-build-service/compare/16da24d76be1...0c925…

1 0

[openSUSE/open-build-service] d083de: Fix trigger controller's rebuild method spec failures
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: d083def7c208704822a6e7b7049d0cab09e926ba https://github.com/openSUSE/open-build-service/commit/d083def7c208704822a6e… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Fix trigger controller's rebuild method spec failures Commit: 16da24d76be148070fcf054ae7f66edf6d969692 https://github.com/openSUSE/open-build-service/commit/16da24d76be148070fcf0… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Merge pull request #11037 from danidoni/fix-trigger-controller-rebuild-method-spec-failures Fix trigger controller's `#runservice` method spec failures Compare: https://github.com/openSUSE/open-build-service/compare/1ac108200292...16da2…

1 0

[openSUSE/open-build-service] 1de0f2: Fix trigger controller's `#release` method spec fa...
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 1de0f22aba0ea395e1b436aa38aeeddaef7148ee https://github.com/openSUSE/open-build-service/commit/1de0f22aba0ea395e1b43… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Fix trigger controller's `#release` method spec failures Commit: 1ac1082002928602a713198e2d766c7db0e0f3a5 https://github.com/openSUSE/open-build-service/commit/1ac1082002928602a7131… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Merge pull request #11038 from danidoni/fix-trigger-controller-release-method-spec-failures Fix trigger controller's release method spec failures Compare: https://github.com/openSUSE/open-build-service/compare/f6bc3668eb0f...1ac10…

1 0

[openSUSE/open-build-service] 9bed78: Add uniqueness validation for token string
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 9bed780a4c7c94fd8873461ba2d6773ec4d2698a https://github.com/openSUSE/open-build-service/commit/9bed780a4c7c94fd88734… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/models/token.rb Log Message: ----------- Add uniqueness validation for token string On the database level we already ensure the uniqueness of the token string through an uniq index. In order to properly test this in the model specs and to have better exception handling, the validation should also be present in the token model. Commit: f6bc3668eb0fba39f274d7eabaad20db4d1afca7 https://github.com/openSUSE/open-build-service/commit/f6bc3668eb0fba39f274d… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/app/models/token.rb Log Message: ----------- Merge pull request #11034 from krauselukas/token_model_uniqueness_validation Add uniqueness validation for token string Compare: https://github.com/openSUSE/open-build-service/compare/f188ed3da888...f6bc3…

1 0

[openSUSE/open-build-service] 591696: Fixes `#rebuild` trigger controller spec failures
by Victor Pereira 26 Apr '21

26 Apr '21

Branch: refs/heads/refactor_trigger_webhooks_controllers Home: https://github.com/openSUSE/open-build-service Commit: 59169689178a28a76f014ad5efbf60e6473daca2 https://github.com/openSUSE/open-build-service/commit/59169689178a28a76f014… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Fixes `#rebuild` trigger controller spec failures Commit: f188ed3da888e2d0cfc2c3a7a705b8e750d07142 https://github.com/openSUSE/open-build-service/commit/f188ed3da888e2d0cfc2c… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Merge pull request #11036 from danidoni/fix-trigger-controller-rebuild-method-spec-failures Fixes `#rebuild` trigger controller spec failures Compare: https://github.com/openSUSE/open-build-service/compare/94dab26013d7...f188e…

1 0

[openSUSE/obs-build] 07ba4c: cross: rename %_sysroot to %cross_sysroot
by Adrian Schröter 24 Apr '21

24 Apr '21

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 07ba4c68a6dfe02258bf115cadf712906e703a28 https://github.com/openSUSE/obs-build/commit/07ba4c68a6dfe02258bf115cadf712… Author: Adrian Schröter <adrian(a)suse.de> Date: 2021-04-24 (Sat, 24 Apr 2021) Changed paths: M init_buildsystem Log Message: ----------- cross: rename %_sysroot to %cross_sysroot

1 0

[openSUSE/obs-build] 87e031: singlejob takes a package name as parameter
by Adrian Schröter 24 Apr '21

24 Apr '21

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 87e0316274454cc8c3b7892f8dadb7bb12a89de8 https://github.com/openSUSE/obs-build/commit/87e0316274454cc8c3b7892f8dadb7… Author: Adrian Schröter <adrian(a)suse.de> Date: 2021-04-24 (Sat, 24 Apr 2021) Changed paths: M PBuild/Checker.pm M PBuild/Options.pm M pbuild Log Message: ----------- singlejob takes a package name as parameter and just builds this one enforced with verbose output

1 0

[openSUSE/obs-build] a27a5a: pbuild: allow native builds when doing cross building
by Michael Schroeder 23 Apr '21

23 Apr '21

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: a27a5a90bdb114f0705819edeecf5c0f82610815 https://github.com/openSUSE/obs-build/commit/a27a5a90bdb114f0705819edeecf5c… Author: Michael Schroeder <mls(a)suse.de> Date: 2021-04-23 (Fri, 23 Apr 2021) Changed paths: M PBuild/Checker.pm M PBuild/Job.pm M PBuild/LocalRepo.pm M PBuild/Recipe.pm M PBuild/RepoMgr.pm M pbuild Log Message: ----------- pbuild: allow native builds when doing cross building This is currently signaled by prefixing the package name with "native-". This is subject to change!

1 0

[openSUSE/obs-build] a6166c: Make sysroot work without --clean
by Adrian Schröter 23 Apr '21

23 Apr '21

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: a6166cb024811840ef0474f46ed62c74a55c0d10 https://github.com/openSUSE/obs-build/commit/a6166cb024811840ef0474f46ed62c… Author: Adrian Schröter <adrian(a)suse.de> Date: 2021-04-23 (Fri, 23 Apr 2021) Changed paths: M build-pkg-rpm Log Message: ----------- Make sysroot work without --clean

1 0