Branch: refs/heads/refactor_trigger_webhooks_controllers
Home: https://github.com/openSUSE/open-build-service
Commit: 6fcf61219557dd3916f4f02849359880e218f799
https://github.com/openSUSE/open-build-service/commit/6fcf61219557dd3916f4f0...
Author: Dany Marcoux
Date: 2021-04-26 (Mon, 26 Apr 2021)
Changed paths:
M src/api/app/controllers/trigger_controller.rb
M src/api/test/functional/source_services_test.rb
Log Message:
-----------
Fix Minitest tests related to trigger_controller
Fixes:
1. Instead of raising the error NoPermissionForActive when authorization
isn't passing, we're doing it with Pundit now. This explains why the
tests had to be changed.
2. `ActionController::UnfilteredParameters: unable to convert unpermitted parameters to hash`
was happening since we didn't run permit on the params.
Commit: afee6fdf60f087d45cfb7a4f7acef525c49dc426
https://github.com/openSUSE/open-build-service/commit/afee6fdf60f087d45cfb7a...
Author: Lukas Krause
Date: 2021-04-26 (Mon, 26 Apr 2021)
Changed paths:
M src/api/app/controllers/trigger_controller.rb
M src/api/test/functional/source_services_test.rb
Log Message:
-----------
Merge pull request #11045 from dmarcoux/refactor_trigger_webhooks_controllers-fix_minitest_tests
Fix Minitest tests related to trigger_controller
Compare: https://github.com/openSUSE/open-build-service/compare/bdbc3c160a52...afee6f...
Lukas Krause