-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/14/2012 10:10 AM, Jan Beulich wrote:
On 14.06.12 at 15:37, Jeff Mahoney
wrote: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/14/2012 04:53 AM, Olaf Hering wrote:
On Tue, Jun 12, Jan Beulich wrote:
While I questioned whether doing this (for a slim boot time benefit this might provide) is really the right thing already in the past, bug 766284 points out another reason why this is a bad idea. Can this be reverted (in master and 12.2 at least)?
The change below for ata_piix (and other related changes in April 2009) was made without a bugzilla or fate reference. Whats the practical benefit of having the drivers built into the kernel? At least ata_piix should be a module because it also drives emulated hardware (not only in a Xen HVM guest).
The changes came out of the faster booting effort at Intel for Meego (or Moblin, or whatever it was called then), since the initialization can happen in parallel rather than waiting on each module to load in the initrd as happens with a mostly-modular kernel. Greg KH added the changes and presented numbers as to why it was faster at the time.
The fact that ata_piix is also used by emulated hardware is not a reason to make it modular. It's a reason to fix the drivers to work together, or to pull the functionality into the original driver.
If the intended driver is modular, then that driver has no way to tell a built-in one to not control certain devices. So the only option then is to use Olaf's patch (which isn't really desirable imo).
From my perspective, if there are two or more drivers for one piece of hardware (ignore the fact that it's virtual/emulated here), they _all_ should be modular, so that the rest of the system (e.g. modprobe rules) can figure out the right one. The situation really is no different than for other cases where a KMP override is wanted/necessary.
- From my perspective, there shouldn't be more than one driver for a given piece of hardware unless one is planned to phase out the other. That doesn't seem to be the case. The emulated one is a special case of the the canonical one and should be integrated. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP2fHBAAoJEB57S2MheeWyhB0P/3GorW9ia7mC0QBM85udbzyr nuZ8ArjgrAlJAPgx+825cvgNeVXnKA/jQa/wih38szr93r4RUqIyEWfe84bXVIuv bi49/rYDup6jkOuOsPd2Igilj+TWVRIPgcthD0Fsy2UFTz64NrVaNgtgt2rwAdOk +WgneGbaKIRwy8bB1xszkXF6phNrmmys9XRWbjXiUeRoZ6IwhD68AlRcJ8qbEkoj Xcvpqg/H/kjXKdUllIUFRxd38lAKOlNJ/xMei+7nKLJV9UP8dsjUFGPpvbgudYwA ScM9DlEs/PY7ca58V2b0RRGlRoalgsYKxYPNThry0biIZOklgDSIfouIWCaQyRsN 1eHl3+rdty1wmIRWpp0jWBWHS/csqhJVUa5UQU2UGCcCAmNcCqQcuhpDW3h3jPU/ SCUZO8bg9v8il70DchIyFYV6ddFesek2z/FTR+4QD3rKpMF3W87iOeTnQYyaWgQT 40xrNLUbZk83uRPXlhIw+xcWcdTpbCvBP2FyvF2rAV0GbSu25c/iM3T7eyWw1vsh KrIjxE2LNNIovLwyti22YzMFS0KCt9ftUYaE2EY7LidZTlXl/B6xiv9TO0XHVe6f JHmf61ILo60S2JKfmsM4sJUeF2GaSKbaPl5NbM4/Z5isAJvGMy79kRxtFh+ZhMfX LpeOWD8kyGODQKtpmGCj =4Etr -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org