[opensuse-factory] dropping duplicated .changes files
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, for valid reasons we have many packages that have related linked packages (e.g. coreutils-testsuite or cross-aarch64-binutils) A pattern that I often found there is to also duplicate the .changes file then, e.g. via pre_checkin.sh: fgrep -l .changes openSUSE:Factory/*/pre_checkin.sh | wc -l 197 so instead of one binutils.changes I have 22 identical .changes files in each of the 22 linked package checkout dirs, a) wasting N^2 space in my checkout (maybe in OBS storage too?) b) forcing me to give a file parameter to 'osc vc' c) requiring me to read pre_checkin.sh to not get my updates wiped by it d) making 'osc status' output harder to read e) making 'osc ci' default commit message less readable by duplicating diffs (same for 'osc sr' ?) Now, when working on https://github.com/openSUSE/obs-build/pull/424 I found that it has rather powerful logic to find the correct .changes file, 1) if you only have one .changes file of any name, it is just taking tha t 2) stripping components (separated by - or .) from the right until it finds a match, taking the shortest matching .changes file name 3) if no match is found, it opts for the shortest available .changes file name And I think, we could use that to get rid of most of the duplication, e.g. having just one binutils.changes file that will be picked up by all linked cross-foo-binutils packages. Or do you know of tools that expect a foo-bar package to contain a foo-bar.changes file and are not happy with a foo.changes being used in the package build? And if so, could we adjust those tools? Any other good reason to keep this duplication that outweighs disadvantages (see above)? Ciao Bernhard M. -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQRk4KvQEtfG32NHprVJNgs7HfuhZAUCWmgOPAAKCRBJNgs7Hfuh ZIOJAJ4godTb39ZJR96eh/9XKjlWp55rQwCgpx9I70C0Hw3Ruw6WVZN/aOhrMM4= =t5vx -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Jan 24 2018, "Bernhard M. Wiedemann"
a) wasting N^2 space in my checkout (maybe in OBS storage too?)
Why N^2? You don't need to check out the links. Also, contents of linked packages are hard-linked in OBS storage. There is also the _multibuild feature which should replace multi-spec packages in the long run. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On 2018-01-24 10:01, Andreas Schwab wrote:
On Jan 24 2018, "Bernhard M. Wiedemann"
wrote: a) wasting N^2 space in my checkout (maybe in OBS storage too?)
Why N^2? You don't need to check out the links. Also, contents of linked packages are hard-linked in OBS storage.
so instead of osc co openSUSE:Factory and later osc up I could do osc up -u to only get a _link file for the others, right?
There is also the _multibuild feature which should replace multi-spec packages in the long run.
OK, so we leave them in until then... according to http://opensuse.14.x6.nabble.com/How-to-use-multibuild-td5076511.html it is already around for 13 months so are we are waiting until Leap-15 is forked off before using it more? -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Jan 24 2018, "Bernhard M. Wiedemann"
On 2018-01-24 10:01, Andreas Schwab wrote:
On Jan 24 2018, "Bernhard M. Wiedemann"
wrote: a) wasting N^2 space in my checkout (maybe in OBS storage too?)
Why N^2? You don't need to check out the links. Also, contents of linked packages are hard-linked in OBS storage.
so instead of osc co openSUSE:Factory and later osc up I could do osc up -u to only get a _link file for the others, right?
osc co or osc up doesn't check out links in the first place. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (2)
-
Andreas Schwab
-
Bernhard M. Wiedemann