On Wednesday May 30 2007, Dries Verachtert wrote:
On Wednesday May 30 2007, Michael Schroeder wrote:
On Wed, May 30, 2007 at 12:02:48PM +0200, Dries Verachtert wrote:
On Tuesday May 22 2007, Dries Verachtert wrote:
On Tuesday May 22 2007, Marcus Rueckert wrote:
On 2007-05-22 14:30:42 +0200, Dries Verachtert wrote:
[ discussion about a way to add something to the release tag ]
If i understand the code correctly, then the release tag is changed by the perl script 'substitutedeps', called from the bash script 'build'. The following small patch would allow some very minimal support for a suffix for the release tag (patch made in the dir trunk/buildservice/src/build/:
This shouldn't be done in substitutedeps, but in the bs_worker program. Basically substitutedeps just substitues what was passed to the build script via the "--release" argument.
Ok thanks for the information! A small patch which adds '%{?releasesuffix}' in bs_worker:
Index: bs_worker =================================================================== --- bs_worker (revision 1692) +++ bs_worker (working copy) @@ -450,11 +450,12 @@
my $release; if (defined($buildinfo->{'release'})) { - $release = $buildinfo->{'release'}; + $release = $buildinfo->{'release'} . "%{?releasesuffix}"; } elsif (defined($buildinfo->{'versrel'}) && defined($buildinfo->{'bcnt'})) { $release = $buildinfo->{'versrel'}; $release =~ s/.*-//; $release .= ".$buildinfo->{'bcnt'}"; + $release .= "%{?releasesuffix}"; } my @args; push @args, $helper if $helper;
Hello Michael, Do you think a patch like this could get included or would you like to have it implemented in a different way? kind regards, Dries --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org