[Bug 792172] New: acpid: remove thinkpad_acpi driver options
https://bugzilla.novell.com/show_bug.cgi?id=792172 https://bugzilla.novell.com/show_bug.cgi?id=792172#c0 Summary: acpid: remove thinkpad_acpi driver options Classification: openSUSE Product: openSUSE Factory Version: 12.3 Milestone 1 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: seife@novell.slipkontur.de QAContact: qa-bugs@suse.de CC: hmacht@suse.com Found By: Third Party Developer/Partner Blocker: --- When investigating why my brightness control was working erroneously in xfce, I found out that the thinkpad_acpi driver sent input events for the brightness keys, but the hardware apparently handled the keys by itself. This resulted in userpace also adjusting brightness, resulting in only 5 to 6 usable steps. looking further, I found options thinkpad_acpi experimental=1 hotkey=0xffffff in /etc/modprobe.d/50-thinkpad_acpi.conf. The driver authors recommend to not use the hotkey= parameter but just let the driver decide what to do. susi:~ # cat /proc/acpi/ibm/hotkey status: enabled mask: 0x00ffffff commands: enable, disable, reset, <mask> susi:~ # echo reset > /proc/acpi/ibm/hotkey susi:~ # cat /proc/acpi/ibm/hotkey status: enabled mask: 0x038c7fff commands: enable, disable, reset, <mask> The driver decides to enable a totally different set of hotkeys than 50-thinkpad_acpi.conf And it is actually working much better with the defaults than it was with 0xffffff... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c
Jiaying ren
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c1
Jiri Slaby
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c2
Stefan Seyfried
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c3
Jiri Slaby
the file belongs to acpid:
susi:~ # rpm -qf /etc/modprobe.d/50-thinkpad_acpi.conf acpid-2.0.19-1.1.x86_64
...as I tried to describe in $SUBJECT :-)
Oh well, why are you using acpid anyway? Eveything should be working without that just fine. And without bugs like these... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c4
Stefan Seyfried
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c5
Jiri Slaby
Well, i'm for example using my own thinkpad_acpi handler to use fn-f1 to enable/disable bluetooth and fn-f11 to enable/disable WWAN. That's just plain easy with acpid.
Note that using acpid is obsolete.
If nobody besides me needs it, we can of course drop it, but if we keep it, we should not keep it broken :-)
Well, but this is nothing for kernel fellows ;). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c
Ye Yuan
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c7
Thomas Renninger
If nobody besides me needs it, we can of course drop it
I submitted a patch to get rid of the /proc/acpi/events interface totally (CONFIG_ACPI_PROC_EVENT=y). If this one goes through, I suggest to get rid of the acpid as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c8
--- Comment #8 from Stefan Seyfried
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c9
--- Comment #9 from Thomas Renninger
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c10
--- Comment #10 from Stefan Seyfried
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c11
--- Comment #11 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c12
--- Comment #12 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=792172
https://bugzilla.novell.com/show_bug.cgi?id=792172#c13
Stefan Seyfried
participants (1)
-
bugzilla_noreply@novell.com