https://bugzilla.novell.com/show_bug.cgi?id=732915
https://bugzilla.novell.com/show_bug.cgi?id=732915#c16
David Woodhouse changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |REOPENED
InfoProvider|toddrme2178@gmail.com |
--- Comment #16 from David Woodhouse 2012-03-29 12:50:21 UTC ---
Thanks for the review. I was lazy with the error handling on setuid(). It
should *always* be running as root when it tries to drop privileges, and the
error case is that it behaves like every other VPN plugin for NetworkManager,
and just runs its VPN client as root. But it *would* be better to abort. I've
fixed it in the following commit, along with the lack of setgid():
http://git.gnome.org/browse/network-manager-openconnect/commit/?id=f88cd279
Regarding the environment for the modprobe call... patches are welcome, but I
can't quite bring myself to care. Note that at least nm-openconnect-openvpn and
nm-openconnect-vpnc are identical in this respect.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.