https://bugzilla.novell.com/show_bug.cgi?id=670582 https://bugzilla.novell.com/show_bug.cgi?id=670582#c0 Summary: yastwc/ws secret generation code Classification: openSUSE Product: openSUSE 11.4 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: P5 - None Component: WebYaST AssignedTo: kkaempf@novell.com ReportedBy: lnussel@novell.com QAContact: qa@suse.de Found By: --- Blocker: --- the secret generation code in the yastws and yastwc scripts look rather awkward. esp the sed call with the hardcoded original value. Note that sed is called on each startup but matches only the first time so this is superfluous overhead. Wouldn't it make more sense to store the secret somewhere below /var and test for it's existence before doing anything expensive? Ie something like if [ ! -e /var/lib/yastws/secret ]; then rake -s secret > /var/lib/yastws/secret fi plus code in environment.rb that reads that file? Or potentially even move all the code to ruby and avoid the extra shell stuff completely? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.