https://bugzilla.novell.com/show_bug.cgi?id=357556 Summary: /proc/net/dev entries limited to u32 in s2io.c neterion nics Product: openSUSE 10.3 Version: Final Platform: IA64 OS/Version: openSUSE 10.3 Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: melchers@zedat.fu-berlin.de QAContact: qa@suse.de Found By: --- values for tx_packets, tx_errors, rx_errors, multicast, rx_length_errors as presented by /proc/net/dev for neterion nics are limited to 32 bit. The problem is, that the assignment in the s2io.c driver, function s2io_get_stats(): sp->stats.tx_packets = le32_to_cpu(mac_control->stats_info->tmac_frms); omits the overflow values tmac_frms_oflow. tx_packets and the other statistics counter are of type "unsigned long", for 64 bit os, the width is 64 bit, so all bits should be used. The correct handling can be seen in the function s2io_get_ethtool_stats(): tmp_stats[i++] = (u64)le32_to_cpu(stat_info->tmac_frms_oflow) << 32 | le32_to_cpu(stat_info->tmac_frms); -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.