https://bugzilla.novell.com/show_bug.cgi?id=220206 ------- Comment #16 from mt@novell.com 2006-11-17 04:06 MST ------- (In reply to comment #11)
Basically I would not mind doing so. Looking at the patch my impression is, that we won't be able to unmount the device in that case. That's ok as we did not mount it.
Yes, we didn't mounted it, so we by default also not umount it.
But we have to make shure our media change workflow behaves reasonable in that case. If commit requires a 2nd CD, the user presses the eject button an nothing happens, we'll get bugreports.
No, this will not happen (at least if automounted at the moment), because the media handler forces an umount & eject if somebody calls release(eject=true). We have two compile time switches now: /* ** try umount of foreign (user/automounter) media on eject ** 0 = don't force, 1 = automounted only, 2 == all */ #define FORCE_RELEASE_FOREIGN 1 /* ** Reuse foreign (user/automounter) mount points. ** 0 = don't use, 1 = automounted only, 2 = all */ #define REUSE_FOREIGN_MOUNTS 2 What happens is [see MediaCD::releaseFrom(bool eject) function]: +++ if( we_mounted_media) umount(media); if( eject) { /* 1 == automounted only (at the moment) */ if(FORCE_RELEASE_FOREIGN) forceRelaseAllMedia(false, FORCE_RELEASE_FOREIGN == 1); if( !openTray( media)) ZYPP_THROW(MediaNotEjectedException(media)); } } The new code line fromn attached patch is marked with +++. What we can do is to set FORCE_RELEASE_FOREIGN to 2 as well, so the media handler will try to umount also not-automounted media on eject. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.