http://bugzilla.novell.com/show_bug.cgi?id=538782
User srinidhi@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=538782#c2
--- Comment #2 from Srinidhi B S
(In reply to comment #0)
Please review and provide feedback.
From what I see so far your patch looks good!
First of all, thanks a lot for reviewing the patch! :)
Just a small remark: lib/frontend_compat.rb: You should add the comment to the PUT request otherwise it'll result in 2 commits (and the first commit has no comment).
According to the apidocs, PUT does not support "cmd=commit&comment=". I just looked at how osc does it, and there too, the comment is sent through a POST. Regarding your concern about "2 commits", if you look at that POST request, there's a "rev=upload" - that ensures that the comment is included into the "upload" revision instead of a new commit / revision. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.