https://bugzilla.novell.com/show_bug.cgi?id=361559
User hvogel@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=361559#c3
--- Comment #3 from Hendrik Vogelsang 2008-03-14 08:40:44 MST ---
This patch is not really a solution. It is only working because you are trying
with the same file. With your patch the result is always file1 overlayed by
file2.
Look at this example:
$ md5sum some.iso
e92c90a23fe9c1b4dd35bf114282b997 some.iso
$ l some.iso
-rw-r--r-- 1 root root 1512357888 2007-10-10 02:38 some.iso
$ md5sum other.iso
3abddaaa6db96472dc9dfc4c8bf4a331 other.iso
$ l other.iso
-rw-r--r-- 1 root root 1500473344 2007-10-10 02:56 other.iso
$ date; curl -s -T some.iso ftp://earl/anon/vsftpd-file-locking; date
Fri Mar 14 15:11:47 CET 2008
$ date; curl -s -T other.iso ftp://earl/anon/vsftpd-file-locking; date
Fri Mar 14 15:11:53 CET 2008
This should result in upload 2 beeing blocked by upload 1 (until finished) and
then in vsftpd-file-locking beeing the same as other.iso. The result is
actually
$ md5sum vsftpd-file-locking
6992b07798a1abc291c7d2fec53a07eb vsftpd-file-locking
$ l vsftpd-file-locking
-rw-r--r-- 1 ftp ftp 1512357888 Mar 14 15:16 vsftpd-file-locking
So again something mangled. The other patch in redhats bugzilla is also only
fixing their testcase and not the problem (you can even truncate the file to
zero by aborting upload2). This needs further investigation by chris i guess.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.