Hi, On Mon, 6 Oct 2008, Duncan Mac-Vicar Prett wrote:
Michael Matz wrote:
But it would be very nice if someone cleaned up the code of MediaAria2c.cc. From a cursory read some weeks ago it is mostly a c&p of MediaCurl.cc (and in fact still uses curl for most of it's things, except of course for the crucial one of downloading files), and exchanged only a couple of functions. I'd much rather see MediaAria2c be a subclass of MediaCurl reusing much of its code.
Yes, that is planned.
Code duplication is bad.
Does that include string join and split functions? ;-)
No, these are carefully crafted to do slightly different things everywhere, and hence can't share any code, of course :-)) Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org