Mailinglist Archive: zypp-commit (266 mails)

< Previous Next >
[zypp-commit] r11705 - in /trunk/libzypp/zypp/ui: Selectable.h SelectableImpl.h
  • From: mlandres@xxxxxxxxxxxxxxxx
  • Date: Tue, 18 Nov 2008 11:37:42 -0000
  • Message-id: <20081118113742.E79309E40D@xxxxxxxxxxxxxxxx>
Author: mlandres
Date: Tue Nov 18 12:37:42 2008
New Revision: 11705

URL: http://svn.opensuse.org/viewcvs/zypp?rev=11705&view=rev
Log:
try to clarify doc

Modified:
trunk/libzypp/zypp/ui/Selectable.h
trunk/libzypp/zypp/ui/SelectableImpl.h

Modified: trunk/libzypp/zypp/ui/Selectable.h
URL:
http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/ui/Selectable.h?rev=11705&r1=11704&r2=11705&view=diff
==============================================================================
--- trunk/libzypp/zypp/ui/Selectable.h (original)
+++ trunk/libzypp/zypp/ui/Selectable.h Tue Nov 18 12:37:42 2008
@@ -119,16 +119,8 @@
/** The last Installed object. */
PoolItem installedObj() const;

- /**
- * Returns one of available objects, specifically either the user
- * selected candidate or a default.
- *
- * Default is either the first available object which has the same arch
- * as one of the installed objects, or the first available object
- * (if none of available arch matches the arch of the installed objects),
- * or empty.
- *
- * \return a PoolItem according to the describe criteria.
+ /** The 'best' or 'most interesting' among all available objects.
+ * One that is, or is likely to be, chosen for installation.
*/
PoolItem candidateObj() const;

@@ -164,12 +156,10 @@
/** \overload */
PoolItem setCandidate( ResObject::constPtr newCandidate_r,
ResStatus::TransactByValue causer_r = ResStatus::USER );

- /**
- * The object whose summary to show in the UIs.
+ /** An object you could use as pars pro toto.
*
- * \return the \ref candidateObj(), if not empty, or the first of
installed
- * objects or an empty \ref PoolItem.
- * \see candidateObj()
+ * \return the \ref candidateObj, or ,if no available objects
+ * exist, the \ref installedObj.
*/
PoolItem theObj() const;


Modified: trunk/libzypp/zypp/ui/SelectableImpl.h
URL:
http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/ui/SelectableImpl.h?rev=11705&r1=11704&r2=11705&view=diff
==============================================================================
--- trunk/libzypp/zypp/ui/SelectableImpl.h (original)
+++ trunk/libzypp/zypp/ui/SelectableImpl.h Tue Nov 18 12:37:42 2008
@@ -214,8 +214,6 @@
if ( !installedEmpty() )
{
// prefer the installed objects arch.
- //! \todo FIXME this is semi-random(?); should rather look for such
installed
- //! object's arch which best matches the system arch
for ( installed_const_iterator iit = installedBegin();
iit != installedEnd(); ++iit )
{

--
To unsubscribe, e-mail: zypp-commit+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-commit+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages