Mailinglist Archive: yast-devel (9 mails)

< Previous Next >
[yast-devel] Re: [yast-commit] r67110 - in /branches/SuSE-Code-11-SP2-Branch/restore: VERSION package/yast2-restore.changes src/Restore.ycp
On Thu, 05 Jan 2012 14:22:57 -0000
locilka@xxxxxxxxxxxxxxxxx wrote:

Author: locilka
Date: Thu Jan 5 15:22:56 2012
New Revision: 67110

URL: http://svn.opensuse.org/viewcvs/yast?rev=67110&view=rev
Log:
- Checking, installing and/or adjusting rpcbind or portmap (as
fallback) before mounting an NFS share (bnc #682064).
- 2.17.6


Modified:
branches/SuSE-Code-11-SP2-Branch/restore/VERSION
branches/SuSE-Code-11-SP2-Branch/restore/package/yast2-restore.changes
branches/SuSE-Code-11-SP2-Branch/restore/src/Restore.ycp

Modified: branches/SuSE-Code-11-SP2-Branch/restore/VERSION
URL:
http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/restore/VERSION?rev=67110&r1=67109&r2=67110&view=diff
==============================================================================
--- branches/SuSE-Code-11-SP2-Branch/restore/VERSION (original) +++
branches/SuSE-Code-11-SP2-Branch/restore/VERSION Thu Jan 5 15:22:56
2012 @@ -1 +1 @@ -2.17.5
+2.17.6

Modified:
branches/SuSE-Code-11-SP2-Branch/restore/package/yast2-restore.changes
URL:
http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/restore/package/yast2-restore.changes?rev=67110&r1=67109&r2=67110&view=diff
==============================================================================
---
branches/SuSE-Code-11-SP2-Branch/restore/package/yast2-restore.changes
(original) +++
branches/SuSE-Code-11-SP2-Branch/restore/package/yast2-restore.changes
Thu Jan 5 15:22:56 2012 @@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Thu Jan 5 15:10:33 CET 2012 - locilka@xxxxxxx + +- Checking,
installing and/or adjusting rpcbind or portmap (as
+ fallback) before mounting an NFS share (bnc #682064).
+- 2.17.6
+
+-------------------------------------------------------------------
Tue Mar 29 09:28:49 CEST 2011 - locilka@xxxxxxx

- Mounting NFS shares with 'nolock' (bnc #682064)

Modified: branches/SuSE-Code-11-SP2-Branch/restore/src/Restore.ycp
URL:
http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/restore/src/Restore.ycp?rev=67110&r1=67109&r2=67110&view=diff
==============================================================================
<snip>
@@ -522,44 +566,19 @@ map parsed_url =
URL::Parse(input); string scheme = parsed_url["scheme"]:"file";

- if (scheme == "nfs")
- {
- string nfs_server = parsed_url["host"]:"";
- //substring(tail, 0, pos);
- string nfs_file = parsed_url["path"]:"";
- //substring(tail, pos + delimiter_correction);
-
- // check if portmapper is installed
- integer result = (integer) SCR::Execute(.target.bash,
"/bin/rpm -q portmap");
- y2milestone("check result: rpm: %1", result);
-
- if (result != 0)
- {
- y2milestone("portmapper package is not installed");
- Package::DoInstall(["portmap"]);
+ if (scheme == "nfs") {
+ if (CheckAndPrepareNFS (parsed_url)) {
+ y2milestone ("NFS-related services adjusted");
+ } else {
+ y2error ("Cannot adjust NFS-related services");

Hi, this is one of the most common annoying behavior of yast. Something
seriously failed. And instead quick response, that something is wrong
with reasonable message, it fails latter with totally confusing message
or not fail at all and just doesn't work. This doesn't make good
image of YAST.

}

- // check if portmapper is running
- integer portmapper_status = Service::Status("portmap");
- y2milestone("portmap status: %1", portmapper_status);
+ y2milestone("NFS source - server: %1 file: %2",
parsed_url["host"]:"", parsed_url["path"]:"");
+ map mountresult = mountNFS(parsed_url["host"]:"",
parsed_url["path"]:"");
- if (portmapper_status != 0)
- {
- // start portmapper
- boolean started = Service::Start("portmap");
- y2milestone("portmap start result: %1", started);
- }
-
- y2milestone("NFS source - server: %1 file: %2",
nfs_server, nfs_file); -
- map mountresult = mountNFS(nfs_server, nfs_file);
-
- if (mountresult["mounted"]:false == false)
- {
+ if (mountresult["mounted"]:false == false) {
y2error("Cannot read source '%1' - NFS mount
failed", input);

And again, you cannot mount NFS. Does user know it? Maybe ideally with
some details what is going wrong. Or what he can do to make it happy.

Josef

- }
- else
- {
+ } else {
mpoint = mountresult["mountpoint"]:"";
file = mpoint + "/" + mountresult["file"]:"";
success = true;




--
Josef Reidinger
Software Engineer Appliance Department

SUSE LINUX, s. r. o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic

jreidinger@xxxxxxxx
SUSE
--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: yast-devel+owner@xxxxxxxxxxxx

< Previous Next >
List Navigation
Follow Ups