Mailinglist Archive: yast-devel (15 mails)

< Previous Next >
Re: [yast-devel] Re: [yast-commit] r66973 - /branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp
Am 01.12.2011 14:44, schrieb Uwe Gansert:
On 01.12.2011 13:00, Josef Reidinger wrote:
http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp?rev=66973&r1=66972&r2=66973&view=diff

==============================================================================

--- branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp
(original) +++
branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp Wed Nov
30 10:58:12 2011 @@ -83,7 +83,10 @@ y2milestone( "Calling %1",
command ); map output = (map)SCR::Execute( .target.bash_output,
command ); y2milestone( "Output: %1", output ); -
+ if ( output["exit"]:255 != 0 )
+ {
+ Popup::Error( sformat( _("Command %1
failed"), command ) );
+ }

I'm not sure if that code can run during autoinstallation but I think so.
Then it's better to use Report::Error(....) because autoyast can timeout
a Report::.... call but a Popup::.... call will always block autoyast.
This popup only can appear if the user clicks on 'Cancel', so I think, no problem here for autoyast.
But a good hint: I have several popups e.g. about failing services when starting the FCoE module, there I will change the code to use Report::Warning()/Error().





--
Gabriele Mohr
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5 Tel: +49 911 740 53 362
90409 Nürnberg Email: gs@xxxxxxx
-----------------------------------------------------------------
--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: yast-devel+owner@xxxxxxxxxxxx

< Previous Next >
List Navigation