Mailinglist Archive: yast-devel (121 mails)

< Previous Next >
Re: [yast-devel] Review code, please
  • From: Lukas Ocilka <lukas.ocilka@xxxxxxx>
  • Date: Tue, 28 Jun 2011 17:00:32 +0200
  • Message-id: <>
Hash: SHA1

Dne 28.6.2011 13:49, Josef Reidinger napsal(a):
Or is everyone already reading everything and finding nothing to
comment on?

BTW one nice blog article about code review

just my notes to stages of code review
1) useless for me, code must say itself what it do
2) really useful, you must see on your own what code do -> code is readable
3) yes, feedback is a must have
4) Revisiting code by code reviewer is for me useless. We should not accept
code which is not good enough, so developer must fix bugs before code is
merged to master.

== Code Reviews: Just Do It ==

~ cut ~
Peer review -- an activity in which people other than the author of a
software deliverable examine it for defects and improvement
opportunities -- is one of the most powerful software quality tools
available. Peer review methods include inspections, walkthroughs, peer
deskchecks, and other similar activities. After experiencing the
benefits of peer reviews for nearly fifteen years, I would never work in
a team that did not perform them.
~ cut ~


- --

Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o.
MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with SUSE -

To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >