Mailinglist Archive: yast-devel (121 mails)

< Previous Next >
Re: [yast-devel] Re: [yast-commit] r64378 - in /trunk/sshd: VERSION package/yast2-sshd.changes src/Sshd.ycp src/dialogs.ycp src/wizards.ycp
  • From: Lukas Ocilka <lukas.ocilka@xxxxxxx>
  • Date: Mon, 20 Jun 2011 09:21:20 +0200
  • Message-id: <4DFEF4F0.50608@suse.cz>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 15.6.2011 17:00, Martin Vidner napsal(a):
On Wed, Jun 15, 2011 at 08:47:50AM -0000, locilka@xxxxxxxxxxxxxxxxx wrote:
Modified: trunk/sshd/package/yast2-sshd.changes
URL:
http://svn.opensuse.org/viewcvs/yast/trunk/sshd/package/yast2-sshd.changes?rev=64378&r1=64377&r2=64378&view=diff
==============================================================================
--- trunk/sshd/package/yast2-sshd.changes (original)
+++ trunk/sshd/package/yast2-sshd.changes Wed Jun 15 10:47:50 2011
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Wed Jun 15 10:45:10 CEST 2011 - locilka@xxxxxxx
+
+- Added possibility to manage the sshd service (#556535).

s/#556535/bnc#556535/

Thx, fixed.

+- 2.21.0
+
+-------------------------------------------------------------------
Wed Jan 13 18:56:03 CET 2010 - kmachalkova@xxxxxxx

- Adjusted .desktop file(s) to wrap /sbin/yast2/ calls in xdg-su

Modified: trunk/sshd/src/Sshd.ycp
URL:
http://svn.opensuse.org/viewcvs/yast/trunk/sshd/src/Sshd.ycp?rev=64378&r1=64377&r2=64378&view=diff
==============================================================================
--- trunk/sshd/src/Sshd.ycp (original)
+++ trunk/sshd/src/Sshd.ycp Wed Jun 15 10:47:50 2011
@@ -30,7 +30,7 @@
/**
* Sleep time between Read or Write steps
*/
-integer sl = 200;
+integer sl = 150;

WTF?

All WTFs have been removed ;)

global boolean Abort() {
@@ -225,7 +223,7 @@
/* SSHD read dialog caption */
string caption = _("Initializing the SSHD Configuration");

- integer steps = 3;
+ integer steps = 4;

aaah, so "integer sl = 600 / steps" above, right?
8-]

This Progress stuff is so... er... useful?

See above. Anyway, good point. The purpose of WTF there was to show
"something" to the user/admin as SSHD was a "tutorial" module. A bit for
effect, not for efficiency.

/**
* Main workflow of the sshd configuration
* @return sequence result
@@ -52,9 +62,49 @@
"services" : [ "service:sshd" ],
"display_details" : true,
]),
+ "start_stop" : CWMServiceStart::CreateStartStopWidget ($[
+ "service_id" : "sshd",
+ // label - service status, informative text
+ "service_running_label" : _("SSH server is running"),
+ // label - service status, informative text
+ "service_not_running_label" : _("SSH server is not running"),
+ // push button (SSH service handling)
+ "start_now_button" : _("&Start SSH Server Now"),
+ // push button (SSH service handling)
+ "stop_now_button" : _("S&top SSH Server Now"),
+ "save_now_action" : SaveAndRestart,
+ // push button (SSH service handling)
+ "save_now_button" : _("Save Settings and Reload SSH Server &Now"),
+ "help" : sformat (CWMServiceStart::StartStopHelpTemplate (true),
+ // part of help text, used to describe pusbuttons (matching SSH
service handling but without "&")
+ _("Start SSH Server Now"),
+ // part of help text, used to describe pusbuttons (matching SSH
service handling but without "&")
+ _("Stop SSH Server Now"),
+ // part of help text, used to describe pusbuttons (matching SSH
service handling but without "&")
+ _("Save Settings and Reload SSH Server Now")),
+ ]),
+ "auto_start_up" : CWMServiceStart::CreateAutoStartWidget ($[
+ "get_service_auto_start" : Sshd::GetStartService,
+ "set_service_auto_start" : Sshd::SetStartService,
+ // radio button (starting SSH service - option 1)
+ "start_auto_button" : _("Now and When &Booting"),
+ // radio button (starting SSH service - option 2)
+ "start_manual_button" : _("&Manually"),
+ "help" : sformat (CWMServiceStart::AutoStartHelpTemplate (),
+ // part of help text, used to describe radiobuttons (matching
starting SSH service but without "&")
+ _("Now and When Booting"),
+ // part of help text, used to describe radiobuttons (matching
starting SSH service but without "&")
+ _("Manually")
+ ),
+ ]),

Hmm, when I saw 'import "CWMServiceStart"' above, I thought "good,
that will save us so much repetitive code" :-/

Overall... God, so much code for a stupid totally standard sysvinit
service?! I want a simple declaration to replace this *entire*
patch:

service :name => _("SSH Server"), :sysvinit => "sshd"

We really should make better libraries.

Yes, but this CWM piece comes from medieval times and we've got to the
19th century just recently. Reaching the 20th or even 21st century will
take us some more time.

Anyway, it's a good point for yast-devel but I'd suggest to open a
separate thread.

Lukas

- --

Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o.
MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iD8DBQFN/vTwVSqMdRCqTiwRAuFqAJ9aRCwkUa+Cbb/Kb/8H+R2RE81YrACdFwM+
MRlTKYNkf9xSK8ElfG1PlFs=
=YBmp
-----END PGP SIGNATURE-----
--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >
References