Mailinglist Archive: yast-devel (128 mails)

< Previous Next >
[yast-devel] Re: [yast-commit] r60856 - in /branches/SuSE-Code-11-Branch/gtk: ChangeLog VERSION tests/Firewall_bnc567505.ycp
  • From: Katarina Machalkova <kmachalkova@xxxxxxx>
  • Date: Thu, 18 Feb 2010 20:16:02 +0100
  • Message-id: <201002182016.02792.kmachalkova@xxxxxxx>
Hi, all

=== --- branches/SuSE-Code-11-Branch/gtk/ChangeLog (original)
+++ branches/SuSE-Code-11-Branch/gtk/ChangeLog Thu Feb 18 18:22:11 2010
@@ -1,3 +1,8 @@
+2010-02-18 Martin Kudlvasr <mkudlvasr@xxxxxxxxxx>
+
+ * tests/Firewall_bnc567505.ycp: add Ricardo's test for bnc#567505
+ * Version 2.17.16

I've just noticed this test-case and also the bug it is associated with.

It's certainly helpful that y2-gtk now handles this situation gracefully and
prevents the whole thing from crashing, but - `item cell and the least of all,
the entire`item content should *never ever* become nil.

If it does, it is a bug in YCP code - think about substituting an empty string
if the value is undefined or eliminate nil's from the term list before passing
it to UI.

The bug (https://bugzilla.novell.com/show_bug.cgi?id=567505) should now be
reassigned to y2-firewall maintainer (with lower priority and/or severity) to
solve the YCP part.

fB.

===========================================================================
=== --- branches/SuSE-Code-11-Branch/gtk/tests/Firewall_bnc567505.ycp
(added) +++ branches/SuSE-Code-11-Branch/gtk/tests/Firewall_bnc567505.ycp
Thu Feb 18 18:22:11 2010 @@ -0,0 +1,21 @@
+// bug 567505
+// GTK UI crashes when cell not set
+
+{
+ UI::OpenDialog(
+ `VBox(
+ `Table(
+ `header("Name", "Price"),
+ [
+ `item(`id(1), "Chili", 6),
+ `item(`id(2), "Salami Baguette", nil),
+ `item(nil), // crash
+ `item(`id(4), "Steak Sandwich", 12)
+ ]
+ ),
+ `PushButton("&OK")
+ )
+ );
+ UI::UserInput();
+ UI::CloseDialog();
+}

--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages