Mailinglist Archive: yast-devel (126 mails)

< Previous Next >
[yast-devel] Re: [yast-commit] <web-client> master : Added Subnet mask string into network module
  • From: Josef Reidinger <jreidinger@xxxxxxx>
  • Date: Fri, 13 Nov 2009 09:59:35 +0100
  • Message-id: <200911130959.35590.jreidinger@xxxxxxx>
Martin Schmidkunz write:
ref: refs/heads/master
commit 8d1e8a1f8e8af1605e9ccbde2ae4286f6e77e200
Author: Martin Schmidkunz <mschmidkunz@xxxxxxx>
Date: Thu Nov 12 14:02:55 2009 +0100

Added Subnet mask string into network module
---
plugins/network/app/views/network/index.html.erb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/network/app/views/network/index.html.erb
b/plugins/network/app/views/network/index.html.erb index 3d51ee6..ce370b6
100644
--- a/plugins/network/app/views/network/index.html.erb
+++ b/plugins/network/app/views/network/index.html.erb
@@ -170,7 +170,7 @@
<%=text_field_tag :ip, @ip, :disabled => static_disabled %>
</p>
<p>
- <label for="<%= :netmask %>"><%=_("Prefixlen")%></label>
+ <label for="<%= :netmask %>"><%=_("Subnet mask /
Prefixlen")%></label> <%=text_field_tag :netmask, @netmask, :disabled =>
static_disabled %> </p>
</fieldset>


Hi, before your commit I change validation to require only Subnet prefix and
according to mzugec, it is easier and allows easy use also if we extend
support for IPv6. So user now can insert only /nn where nn is prefix of site.
Is there reason to allow also subnet mask?
thanks
Josef

--
Josef Reidinger
YaST team
maintainer of perl-Bootloader, YaST2-Repair, webyast
(language,time,basesystem,ntp)
--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages