Mailinglist Archive: yast-devel (233 mails)

< Previous Next >
Re: [yast-devel] Re: [yast-commit] <rest-service> master : fixing packaging ...
  • From: Josef Reidinger <jreidinger@xxxxxxx>
  • Date: Fri, 9 Oct 2009 09:02:21 +0200
  • Message-id: <200910090902.21152.jreidinger@xxxxxxx>
Klaus Kaempf write:
* Josef Reidinger <jreidinger@xxxxxxx> [Oct 09. 2009 08:24]:
File.join(File.dirname(__FILE__),"..","..","config","resources") -
VAR_DIR = File.join(File.dirname(__FILE__),"..","..","var") +
VAR_DIR =
File.join(File.dirname(__FILE__),"/var","lib","yastws","eulas") +
RESOURCES_DIR =
File.join(File.dirname(__FILE__),"/usr","share","yastws","eulas")

^^^
Hi, I think you don't want this path. you join directory of current
exucuted file with absolute path. so it should be (no __FILE__)
File.join("/usr","share","yastws","eulas")

And, while we're at it, we must generally refrain from hard-coding
fixed pathes into the application.

Yes, I agree. It should be in some module where is defined prefix constants.
If you want I can look at it and create it.

Klaus
---
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N├╝rnberg)


--
Josef Reidinger
YaST team
maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and
time
--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups