Mailinglist Archive: yast-devel (40 mails)

< Previous Next >
[yast-devel] roodi ruby code checker available
  • From: Duncan Mac-Vicar Prett <dmacvicar@xxxxxxx>
  • Date: Wed, 22 Apr 2009 16:15:38 +0200
  • Message-id: <49EF268A.5060904@xxxxxxx>

I have packaged roodi in home:dmacvicar:ruby (which I will submit to
devel:languages:ruby:extensions ) as soon as it finished building.

Then we should integrate it with an easy rake task, but you can use it
manually also...

Right now, running it on the controllers already shows stuff to improve
:-) it even blamed my method "show_FIXME"

dmacvicar@piscola:/space/git/web-client/webclient> roodi app/controllers/*
app/controllers/application_controller.rb:50 - Method name
"set_permissions" cyclomatic complexity is 9. It should be 8 or less.
app/controllers/permissions_controller.rb:7 - Method name "show_subtree"
cyclomatic complexity is 11. It should be 8 or less.
app/controllers/permissions_controller.rb:54 - Method name
"build_java_variable" cyclomatic complexity is 10. It should be 8 or less.
app/controllers/permissions_controller.rb:109 - Method name
"set_permission" cyclomatic complexity is 11. It should be 8 or less.
app/controllers/sessions_controller.rb:109 - Method name "create"
cyclomatic complexity is 11. It should be 8 or less.
app/controllers/permissions_controller.rb:54 - Method name
"build_java_variable" has 6 parameters. It should have 5 or less.
app/controllers/permissions_controller.rb:10 - Block cyclomatic
complexity is 10. It should be 4 or less.
app/controllers/permissions_controller.rb:55 - Block cyclomatic
complexity is 10. It should be 4 or less.
app/controllers/sessions_controller.rb:19 - Block cyclomatic complexity
is 7. It should be 4 or less.
app/controllers/sessions_controller.rb:58 - Method name "show_FIXME"
should match pattern /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/
app/controllers/sessions_controller.rb:185 - Method name "updateMenu"
should match pattern /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/
app/controllers/sessions_controller.rb:189 - Method name "updateLogout"
should match pattern /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/
app/controllers/application_controller.rb:50 - Method "set_permissions"
has 26 lines. It should have 20 or less.
app/controllers/permissions_controller.rb:7 - Method "show_subtree" has
25 lines. It should have 20 or less.
app/controllers/permissions_controller.rb:109 - Method "set_permission"
has 40 lines. It should have 20 or less.
app/controllers/sessions_controller.rb:58 - Method "show_FIXME" has 22
lines. It should have 20 or less.
app/controllers/sessions_controller.rb:109 - Method "create" has 43
lines. It should have 20 or less.
app/controllers/permissions_controller.rb:112 - Don't use 'for' loops.
Use Enumerable.each instead.

--
Duncan Mac-Vicar P. - Engineering Manager, YaST
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)

--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages