Mailinglist Archive: yast-commit (1173 mails)

< Previous Next >
[yast-commit] [yast/yast-dhcp-server] 62e07e: Avoid module to crash when dhcp service is not pre...
Branch: refs/heads/master
Home: https://github.com/yast/yast-dhcp-server
Commit: 62e07ed411837be190aa8b7f6c627049d3e0096d

https://github.com/yast/yast-dhcp-server/commit/62e07ed411837be190aa8b7f6c627049d3e0096d
Author: David Díaz <1691872+dgdavid@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: 2018-08-23 (Thu, 23 Aug 2018)

Changed paths:
M package/yast2-dhcp-server.changes
M package/yast2-dhcp-server.spec
M src/include/dhcp-server/dialogs2.rb
M src/modules/DhcpServerUI.rb

Log Message:
-----------
Avoid module to crash when dhcp service is not present (#34)

* Remove not longer used code

* Remove not necessary "start up" extra widget

Since there is being used the new ServiceWidget[1] it is not necessary
to instance it twice, one per "dialog". This allows to prevent the
module crash when the service is not available, asking to user if want
to install it first (which is the expected behavior).

[1]
https://github.com/yast/yast-yast2/blob/3586c81122b39acba5881c2720dae5b346444463/library/systemd/src/lib/yast2/service_widget.rb

* Update version and changelog



**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

Functionality will be removed from GitHub.com on January 31st, 2019.
< Previous Next >
This Thread
  • No further messages