Mailinglist Archive: yast-commit (2114 mails)

< Previous Next >
[yast-commit] <web-client> use-activeresource : Do not log the password!
  • From: Martin Vidner <mvidner@xxxxxxx>
  • Date: Tue, 15 Sep 2009 15:20:04 +0200
  • Message-id: <E1MoJ2X-0003O3-B9@xxxxxxxxxxxxxxxx>
ref: refs/heads/use-activeresource
commit 0c1f935687b8e53d4ab96bebaf34289fe64ac6f5
Author: Martin Vidner <mvidner@xxxxxxx>
Date: Tue Sep 15 14:35:40 2009 +0200

Do not log the password!
---
webclient/app/models/account.rb | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/webclient/app/models/account.rb b/webclient/app/models/account.rb
index 638c2d1..60f5e3f 100644
--- a/webclient/app/models/account.rb
+++ b/webclient/app/models/account.rb
@@ -50,7 +50,8 @@ class Account < ActiveRecord::Base
YaST::ServiceResource::Base.site = uri
# create a login resource
ret = YaST::ServiceResource::Login.create(:login => login, :password
=>passwd, :remember_me => true)
- logger.debug ret.inspect
+ # this would log the password!
+ # logger.debug ret.inspect
if (ret and ret.attributes["login"] == "granted")
@password = passwd
acc = find_by_login(login)
--
To unsubscribe, e-mail: yast-commit+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-commit+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages