28 Feb
2008
28 Feb
'08
22:53
Hi, In trying to understand a bit how the driver works, I've stumbled upon a bit of unreachable code. In rhd_mc.c line 156ff there is an if: // line 156: if (rhdPtr->ChipSet < RHD_R600) { // ... // line 174: } else if (rhdPtr->ChipSet < RHD_R600) { // ... Obviously, the else if case can never be reached. On a side note, I believe the two cases could be merged by putting a few more register offsets into variables, thus reducing code redundancy. Attached patch takes the guess that the first if really wants to test against RHD_RS690 and implements the additional suggestion. Sebastian Redl