Mailinglist Archive: radeonhd (699 mails)

< Previous Next >
Re: [radeonhd] strange git commit
  • From: Luc Verhaegen <libv@xxxxxxxxx>
  • Date: Thu, 22 Nov 2007 23:13:32 +0100
  • Message-id: <20071122221332.GA2487@xxxxxxxxx>
On Thu, Nov 22, 2007 at 09:15:38PM +0100, Hermann Gausterer wrote:
hi

i think this git commit looks a little bit strange:

http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commitdiff;h=ed9065a4288b92d4e3c286071b1a452bb1756a88

+ /* R600 adds an undocumented register at 0x7AD8,
+ * shifting all subsequent registers by exactly one. */
.....SNIP.....
+ LVTMA_R600_REG_TEST_OUTPUT = 0x7B18,
+
+ LVTMA_RS690_NOT_DOCUMENTED = 0x7B18,

the comment tells that the undocumented register is at 0x7AD8
and the code defines the undocumented register to another
offset which allready defined; i think this is a type!

mfg hermann

You are absolutely correct. This is not a typo, this is just badly
thought through. This is a documented register of course, so i badly
blame ATI for my own stupidity.

There are no adverse side effects, the end result is the same for rs690,
but it will be fixed asap.

Luc Verhaegen.
SUSE/Novell X Driver Developer.
--
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups
References