Mailinglist Archive: radeonhd (699 mails)

< Previous Next >
[radeonhd] [PATCH 0/4] Fixes to my git-commit-in-program-messages code
  • From: Hans Ulrich Niedermann <hun@xxxxxxxxxxxxxxxx>
  • Date: Sun, 04 Nov 2007 02:18:48 +0100
  • Message-id: <472D1DF8.7090907@xxxxxxxxxxxxxxxx>
I'm sorry to have to announce that the code from me which has just been
integrated into official xf86-video-radeonhd contains a few bugs. This
patch set should address them.

Issue 1:
If srcdir==builddir, git commit and branch will be in git_version.h.

Solution 1:
Handle directories correctly. Trivial fix. You may hit me on the head.
Verified with imake build, automake srcdir==builddir build, automake
srcdir!=builddir build.

Issue 2:
rhd_conntest requires pci/pci.h and links against -lpci and -lz.
Building it by default will abort the whole build if any one of these
prerequirements is not met.

Solution 2, automake part:
For automake builds, check for appropriate presence of pciutils and
zlib. Only if both prerequirements are met, rhd_conntest is built.

Solution 2, imake part:
For imake builds, do not recurse into utils/conntest any more. "xmkmf
-a" seems to directly read SUBDIRS, so that includes utils/conntest.
However, the FooSubdirs() imake macros are only called on "src man" dirs
- that avoids the default build in utils/conntest.

The imake part "works for me", but as I am not that familiar with imake,
I'd appreciate confirmation from someone who is.

Hans Ulrich Niedermann
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx

< Previous Next >