Mailinglist Archive: opensuse-translation (33 mails)

< Previous Next >
Re: [opensuse-translation] SLE Merge Robot in Weblate libzypp
2016-05-16 10:12 GMT-03:00 Stanislav Brabec <sbrabec@xxxxxxx>:
Luiz Fernando Ranghetti wrote:


When will be ready/in prodution the coordinator/reviewer role?

Well, the feature called "Group ACL"[1] is already on the server.

It is possible to set it up for particular language.

However there are two (small) problems: Once enabled, no translations for
language x will pass to the project before review. If the review team is
busy, it can be a problem. There is a new feature request: Pending review[2]
- string will pass, but a (new) Review flag is set.

Second problem is that it is not properly implemented. There are two bugs
that eliminate one the other. It works only in a single model:
Users outside group have no permissions except Can add suggestion. (So they
cannot e. g. use Upload file. (See also [3].))

If you want to become a tester of this feature, I can enable it for pt_BR
and assign people to your team. If will imply that only members of the
review team can review suggestions from SLE Merge Robot.

References:

[1] add support for language reviewers
https://github.com/nijel/weblate/issues/867

[2] support for traditional review-based workflow
https://github.com/nijel/weblate/issues/1073

[3] permission clash: can edit × can upload
https://github.com/nijel/weblate/issues/1111


Technical description:

- New group "Language x reviewers" is created. This group will get all
privileges of group "Users" (all registered users).

- Group ACL for language x is assigned to this group. Since this moment,
standard "User" permission stops to apply for language x.

- Users that are not in group "Language x reviewers" will lose all
permissions to the particular language except selected permitted ones. They
will typically have only "Suggestion" permission.

- Only users in group "Language x reviewers" have permission to edit
particular language, and possibly add more users to the group (not yet
implemented in a safe way yet, any person with this permission can now add
people to any review group).


Actually, the feature author (Jan Matějek) found that however the above can
be already done, the implementation is not correct. In fact, users outside
assigned ACL group will lose all permissions except Can add Suggestion,
independently on configuration.

--
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------


Hi,

I like the review step, but will wait until it's properly implemented.

Regards,

Luiz
--
To unsubscribe, e-mail: opensuse-translation+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-translation+owner@xxxxxxxxxxxx

< Previous Next >