On Mon, 2019-05-13 at 15:55 +0200, Ludwig Nussel wrote:
Looking at the package I see it writes to /sys in %posttrans. Not sure what that causes exactly but most certainly you don't want that it buildroots, container builds or installation environments etc. So should rather be done on service start up or system boot.
It uses the sysfs interface of the kernel module to recheck (discover) nvme devices provided over Network via Fibre Channel. This will then trigger udev-events, which are handled by systemd-services and nvme (the user-space binary), both shipped by the nvme-cli package. Which means if we upgrade the nvme-cli packages it makes sense to retrigger the udev-events, because the handling via the systemd- services and nvme could have changed. The nvmefc-boot-connections.service, which does the same at boot, is inactive after booting, so the package upgrade won't restart it. The echo in the %posttrans section seemed to be the simplest solution, but I am open for improvements. Cheers Simon -- 6DFE EAC6 CB38 1F78 5FDA 91F3 AC64 34A6 41FC 10F5