20 Aug
2015
20 Aug
'15
13:04
On Thu, 2015-08-20 at 13:16 +0200, jcsl wrote:
I'd like to add a patch to LXPanel for it to make a systemwide themes search. I don't know neither C nor GTK so I'm not sure about the quality and possible bugs in the patch. I did my best but...
https://build.opensuse.org/package/view_file/home:jcsl:test/lxpanel/lxpanel-...
I'm not an LXDE hacker, but purely from a C/GTK+ perspective, the patch looks fine to me. I'd change if (dir) while (dir[0]) { ... } to if (dir) { while (dir[0]) { } } for clarity, though. -- Hans Petter -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org