Stanislav Brabec schrieb:
Olaf Hering wrote:
On Wed, Nov 12, Stanislav Brabec wrote:
There are still ways to force-enable services in packages, even without presets and review.
How many of them are buggy, and should be solved in some other way? For example whenever I disable xen to use my private copy it will be reenabled during the next update of the xen-tools package.
Maybe the concern with doing it that way was that presets do not trigger if the packages are installed (not upgraded) later.
If packages use presets and %service_add_pre/post, then such incorrect behavior does not happen. If preset defines default-on, service is enabled just once on the first installation and never more.
If packages do that by systemctl [--force] enable, they not only obey security review, but package maintainers also have to handle upgrade process on their own. And most of them don't do it correctly. [...] Presets added later than services (from util-linux.spec, works only if the preset is part of the package):
%pre %service_add_pre {service}.service if [ $1 -gt 1 ] ; then if ! test -f /usr/lib/systemd/system-preset/{service preset file} ; then echo -n "" >/run/rpm-%{name}-update-{service}.socket-new-in-upgrade fi fi
That is no longer necessary. %service_add_pre does that itself since January. cu Ludwig -- (o_ Ludwig Nussel //\ V_/_ http://www.suse.de/ SUSE LINUX GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg) Maxfeldstraße 5; 90409 Nürnberg; Germany -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org