Mailinglist Archive: opensuse-packaging (155 mails)

< Previous Next >
Re: [opensuse-packaging] Re: Proper version scheme for packages from git, hg, svn, ...
  • From: Adam Spiers <aspiers@xxxxxxxx>
  • Date: Sat, 11 Jan 2014 16:34:59 +0000
  • Message-id: <20140111163459.GG13009@pacific.linksys.moosehall>
Andrey Borzenkov (arvidjaar@xxxxxxxxx) wrote:
В Sat, 11 Jan 2014 08:47:18 +0100 (CET)
Jan Engelhardt <jengelh@xxxxxxx> пишет:

my @args = ("git", "describe", "--match=$pattern",
"--abbrev=0", $commit);

Should not it use --first-parent? Otherwise there is risk to pick up
wrong tag from merged branch.

That sounds like a good point, but Jan has since proposed a new design
which uses a fixed base tag rather than --match, and hence eliminates
any risk of picking up the wrong tag.

chomp(my $len = `git rev-list "$commit" | wc -l`);

Why not "git rev-list --count $commit"? (Same comment about
--first-parent)

+1 :)
--
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-packaging+owner@xxxxxxxxxxxx

< Previous Next >