Mailinglist Archive: opensuse-packaging (174 mails)

< Previous Next >
Re: [opensuse-packaging] Request for testcases on spec-cleaner
Hello,

Am Donnerstag, 21. November 2013 schrieb Tomáš Chvátal:
As part of the hackweek efforts we in openSUSE Team are going to have
next week I plan to work forward on spec-cleaner tool that is
intended to be superset of the prepare_spec perl magic with something
more readable and with testcases. [1]

So what I would need is if you could take it on your specs and if it
screw up (like for sure it will in its current state) write out start
-> desired output files so I can convert it to testsuite and have it
checked.

You asked for it... ;-)

I just tested with security:apparmor apparmor.spec, and the result looks
interesting[tm]. I'm quite sure you can make some testcases from it ;-)

Some examples:

- Requires: perl(DBD::SQLite) -> Requires: perl(DBD
Requires: SQLite)
It should be obvious what is wrong ;-)

- %makeinstall -C utils -> make DESTDIR=%{buildroot} install %{?_smp_mflags}
Are you really serious about not using %makeinstall? IMHO DESTDIR=...
just adds noise to the spec.

- rm -fv %{buildroot}%{_libdir}/libapparmor.la
%{buildroot}%{_libdir}/libimmunix.la
-> find %{buildroot} -type f -name "*.la" -delete -print
The original code removes only two *.la files, not all.
(I'd have to check if there are other *.la files, but the point is that
spec-cleaner changes the behaviour.)

- %dir %attr(-, root, root) %{_sysconfdir}/apparmor -> %dir %attr(-,
Already known as https://bugzilla.novell.com/show_bug.cgi?id=734920

That are the most important issues I noticed.
spec-cleaner does many more changes, so I'd like to ask you to check
the changes it does to apparmor.spec yourself. Many changes are OK,
but I'm quite sure there are also some not-so-good changes that I
didn't mention above.

That all said - enjoy the hackweek!


Regards,

Christian Boltz
--
Antwort: AW: Antwort: AW: Antwort: AW:
Arrgl ... <mit Schaum vor dem Mund nach hinten umkipp>
[Martin Wilhelm Leidig in suse-linux]

--
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-packaging+owner@xxxxxxxxxxxx

< Previous Next >
References