* Greg Freemyer <greg.freemyer@gmail.com> [2013-05-06 18:18]:
On Mon, May 6, 2013 at 7:26 AM, Adam Spiers <aspiers@suse.com> wrote:
Greg Freemyer (greg.freemyer@gmail.com) wrote:
Adam Spiers <aspiers@suse.com> wrote: <snip>
It's also unclear how I should add a line
# PATCH-FIX-OPENSUSE fix-for-opensuse-specific-things.patch bnc#123456
when there is no bnc entry. If it's OK to omit the bnc# field, the page should say that. Or if it's not, the page should explicitly say that a bugzilla entry should be filed if one doesn't already exist.
For SRs to devel project or factory a bnc is not required on new patches . For patches to released packages that will go out as updates, they should be required. I don't know if that is enforced by the maintenance/security team in the specfile, but it is in the changes file. (Ie. All post release updates require a bnc entry in the changes file.)
Many thanks for the info but again I think it would be more useful if people spent the time improving the wiki pages for this rather than giving the information in this thread where its life span is very low.
I updated:
# PATCH-{FIX|FEATURE}-{OPENSUSE|SLE|UPSTREAM} ''name-of-file.patch'' bnc#<VAR >[0-9]*</VAR > <VAR >you</VAR >@<VAR >example.com</VAR > -- ''this patch makes things totally awesome'' If there are related bugs in [http://bugzilla.novell.com Novell] or other bugzillas, please add them, it will help us to get more accurate information. If there are two or more available then it's preferable to list both (or more).
To have this additional paragraph:
In general, if a patch is only destined to home/devel/factory projects a bugzilla entry is not required on new patches. For patches to released packages that will go out as updates, a bugzilla entry and reference is required as is a reference to the BNC# in the changes file.
The primary use case of the patch field should be references to *upstream* bug trackers in case of PATCH-*-UPSTREAM patches, such patches should be submitted upstream first and then referenced in the patch tag. That helps a lot to keep track of patches, e.g. I have a script that generates a HTML report from patch tags to help me keep track of submitted patches, furthermore it makes it easy to determine which patches are still needed on version updates if upstream references the bug numbers in their changelog or release notes. Of course if there is already a corresponding bnc# bug open it should be referenced as well. -- Guido Berhoerster -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org