Mailinglist Archive: opensuse-packaging (267 mails)

< Previous Next >
Re: [opensuse-packaging] package looking for maintainer: the AT daemon
On Wednesday 28 November 2012, Cristian Rodríguez wrote:
El 26/11/12 15:34, Christian Boltz escribió:
Hello,

Am Montag, 5. November 2012 schrieb Ralf Lang:
Am 04.11.2012 16:40, schrieb Christian Boltz:
Am Samstag, 3. November 2012 schrieb Ralf Lang:
Am 03.11.2012 03:29, schrieb Cristian Rodríguez:

At the risk of scaring you away - one of the first things the
future maintainer (you?) should do is an update for 12.2 because
atd doesn't start at all (already fixed in the devel project) and
the sysconfig options are ignored by the at.service file. See
https://bugzilla.novell.com/show_bug.cgi?id=780259 for details.

I just fixed this - atd.service now contains:
ExecStart=/bin/bash -c '[ -e /etc/sysconfig/atd ] && .
/etc/sysconfig/atd; exec /usr/sbin/atd $${ATD_BATCH_INTERVAL:+-b
$$ATD_BATCH_INTERVAL} $${ATD_LOADAVG:+-l $$ATD_LOADAVG}'

(should I have added a comment "# looks ugly, but works"? ;-)

See
- request #142950 to Base:System
- request #142949 for the 12.2 update

OK, I just now submitted a proper fix ;) created request id 143492

I rest my case with this thing though ;)


Apart from that I find it very ugly to introduce the libHX dependency
just to parse 2 lines from a bash style sysconfig config file there are
some issues with that patch.

Command line arguments should override the config file and not the other
way around.
The arguments from the config options should be parsed like the
commandline ones inclusive error handling and not using atoi and atof.
Config file should be mentioned in the man page.

cu,
Rudi
--
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-packaging+owner@xxxxxxxxxxxx

< Previous Next >
Follow Ups