1 Nov
2010
1 Nov
'10
20:16
2010/11/1 Malcolm: > The openSUSE desktop file, is that something you have added to the > source tarball? Yes, this is getting messy. I see you have write perms in the upstream SVN and that you added openSUSE specific .desktop files. There is no need for such a thing, the only thing needed is to fix the original .desktop file. After that you will not need to call %suse_update_desktop_file with "-i" anymore. The openSUSE .desktop file contains: [Desktop Entry] Encoding=UTF-8 Type=Application Categories=Education;Science;MedicalSoftware; Name=FreeDiams GenericName[en]=Open source prescriber GenericName[fr]=Prescripteur open source Comment[en]=Open source prescriber Comment[fr]=Prescripteur open source TryExec=freediams Exec=freediams Icon=freediams and the original: [Desktop Entry] Version=0.4.0 Type=Application Categories=Office;MedicalSoftware Name=FreeDiams Comment[en]=Pharmaceutical Drugs Prescriptor Comment[fr]=Prescripteur TryExec=freediams Exec=freediams Icon=freediams Correcting over the original to obtain the only file that should be there: - Remove the Version key or set it to 1.0. It is NOT supposed to provide the version of the app... not in openSUSE, not in any other distro - I don't know the app, no idea what Categories should be specified... but they should be the same for every distro, nothing specific of openSUSE here. But they MUST end with a semicolon - The Comment key indeed seems more correct as GenericName. But the '[en]' from "Comment[en]" MUST be removed since the spec specifies an entry without locale is "required" >From the openSUSE specific: - As desktop-file-validate will say, the "Encoding" key is deprecated - The Comment key should be removed since the spec says "The value should not be redundant with the values of Name and GenericName" Upstream also provides the menu icon, doesn't? (global_resources/pixmap/svg/freemedforms-48.png), no need for an openSUSE specific one. If isn't automatically installed, it could be good to patch the build system directly in upstream. Since it provides it in multiples sizes you could put them inside /usr/share/icons, following the Icon Theme Specification. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org