On 05/02/2010 04:05 AM, Philipp Thomas wrote:
On Sat, 01 May 2010 16:32:44 +0200, Dave Plater
wrote: I've searched and can only find exit(0) or exit(-1)
And that are the culprits! But only one who is intimately familiar with a library should try to change that. If you'd change the library you'd also have to check all users of the library and make them cope with the changed behaviour.
This library is only used by jack for firewire music equipment support.
So I'd recommend asking upstreams for changes and in the meantime either ignore the warning or use a rpmlintrc file to suppress te warning.
Philipp
I'm a bit confused about what the rpmlint message actually means, there is one "exit@@GLIBC_2.2.5" in libffado.so.2.0.0 but what I don't quite grasp is exit(0) returns success and exit(-1) returns error so what is the problem with that over return? Please excuse me, I have extensive experience with assemblers, test equipment scripts and hardware but I'm a novice with c and c++. The rpmlint message:- libffado2.x86_64: W: shared-lib-calls-exit /usr/lib64/libffado.so.2.0.0 exit@GLIBC_2.2.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. Thanks Dave P -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org