Re: [opensuse-kernel] Re: [PATCH] config/armv6: Disable KEYBOARD_TM2_TOUCHKEY

On mer., 2017-05-03 at 12:16 +0200, Andreas Färber wrote:

Hi Jean,

Am 03.05.2017 um 11:54 schrieb Jean Delvare:

...

The Samsung TM2 board is based on an Exynos SoC, which the armv6 kernel does not support.

Signed-off-by: Jean Delvare --- For the master branch. I can commit it myself if there is an agreement.

No objection to the change, but a preference for "config: armv6hl: ..." for git-log consistency.

Sure, fixed.

Is there a special reason you're singling out this driver? There is also no OMAP4 on armv6hl, two lines above.

Option KEYBOARD_TM2_TOUCHKEY was just added to kernel v4.11, so I noticed it. I am trying to convince upstream to make it depend on ARCH_EXYNOS to limit its visibility, but no success so far :-( KEYBOARD_OMAP4 must be much older, but I already have a hard time coping with new options, I just don't have the bandwidth to check older ones, sorry.

I wonder whether we could "annotate" or lock such individually-disabled options, in case me or someone gets a request for enabling touchscreens and notices the apparent "inconsistency"?

I use "git blame" for the purpose, assuming commit messages are good. Yeah, I know, I'm naïve, that's very touching. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org