Mailinglist Archive: opensuse-kernel (75 mails)

< Previous Next >
[opensuse-kernel] Inconsistency in patch kconfig-automate-kernel-desktop
Hi all,

Our SUSE-specific kernel patch kconfig-automate-kernel-desktop does the
following:

--- a/init/Kconfig
+++ b/init/Kconfig
@@ -32,6 +32,12 @@ config SPLIT_PACKAGE
If you aren't packaging a kernel for distribution, it's safe to
say n.

+config KERNEL_DESKTOP
+ bool "Kernel to suit desktop workloads"
+ help
+ This is an option used to tune kernel parameters to better suit
+ desktop workloads.
+
config ARCH
string
option env="ARCH"
@@ -537,6 +537,7 @@

menuconfig CGROUPS
boolean "Control Group support"
+ default !KERNEL_DESKTOP
help
This option adds support for grouping sets of processes together, for
use with process control subsystems such as Cpusets, CFS, memory
@@ -651,7 +653,7 @@

menuconfig CGROUP_SCHED
bool "Group CPU scheduler"
- default n
+ default !KERNEL_DESKTOP
help
This feature lets CPU scheduler recognize task groups and control CPU
bandwidth allocation to such task groups. It uses cgroups to group

However, since July 2010 and commit 5183692d, both CGROUPS and
CGROUP_SCHED are enabled in desktop kernels too. The commit message
suggests that this is a requirement for systemd.
http://cgit.freedesktop.org/systemd/systemd/tree/README confirms that
for CGROUPS, thus I believe this chunk should be removed from patch
kconfig-automate-kernel-desktop.

For CGROUP_SCHED, I'm not sure, as the page says "it's OK to disable all
controllers" but the Kconfig strings don't clearly say which options are
controllers. OTOH, CGROUP_SCHED is selected by SCHED_AUTOGROUP, which
was explicitly enabled on desktop kernels only in November 2010 (commit
2d5d3970) and the Kconfig help text suggests it was a good idea. Thus I
believe the CGROUP_SCHED chunk should also be removed from patch
kconfig-automate-kernel-desktop.

If anyone disagrees, please let me know quickly, otherwise I'll proceed
with dropping the desktop-specific defaults for CGROUPS and
CGROUP_SCHED.

--
Jean Delvare
SUSE L3 Support

--
To unsubscribe, e-mail: opensuse-kernel+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-kernel+owner@xxxxxxxxxxxx

< Previous Next >
Follow Ups