On Wed, 2012-06-27 at 10:12 -0400, Jeff Mahoney wrote:
On 6/27/12 9:55 AM, Mike Galbraith wrote:
On Wed, 2012-06-27 at 15:10 +0200, Michal Marek wrote:
On 27.6.2012 06:11, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break
It will break.
That's rather disheartening, because it's already been done and pushed.
It'll break in the manner you already saw -- have two commits instead of the one you intended. Since all of the solutions would have added commits, it's no worse than the other solutions would have been.
Ok. Sorry for the fuss, I'll watch my changelog verbosity. -Mike -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org