On 27.6.2012 06:11, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break
It will break.
things since you've already pushed. If that works, it'd be ideal. Otherwise, a "previous commit did xyz (bnc#...)" commit will probably be the cleanest.
Yes, for now, I think this is the best option. In the future, I think we will need a file with changelog fixups and use it when generating the rpm changelog. A simple format commit 1234deadbeef <new changelog> should do. But this is the first issue with the changelog since kernel-source.changes has been removed two years ago, that is not bad at all :). Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org