Re: [opensuse-kernel] Re: [patch 3/5] [PATCH] scripts/sequence-patch.sh: Add --kabi sub-option to --config

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/19/2011 12:53 PM, Michal Marek wrote:

Dne 19.1.2011 18:29, Jeff Mahoney napsal(a):

...

Now that we have arch and flavor information via the --config option, we can do things like automatically expand the kABI references.

This patch uses that information to expand the references into the build directory. Missing kABI references are not considered a fatal error.

Signed-off-by: Jeff Mahoney --- [...] + + if test -n "$KABI"; then

If you set the variable to true/false, then you can simply write 'if $KABI; then', like in other places in the script.

...

+ echo "[ Expanding kABI references for $CONFIG ]" + rpm/modversions --unpack "$SP_BUILD_DIR"< \ + "kabi/$CONFIG_ARCH/symtypes-$CONFIG_FLAVOR"

Contrary to the changelog, there is no check if the symtypes file is actually present. Also, old branches do not have the modversions script.

Ah, you're right. I had broken these out of one big patch and missed that check. - -Jeff

...

+ else + echo "[ No kABI references for $CONFIG ]" + fi fi

Michal

- -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk03JFEACgkQLPWxlyuTD7IVkACdEUv+Mb2uh97zjlcNaxxVHgcy MhQAniVmn8s/bdXrgYRi+LHT6OiQHZcK =fU1R -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org