Mailinglist Archive: opensuse-gnome (174 mails)

< Previous Next >
[opensuse-gnome] libwnck patches
  • From: Vincent Untz <vuntz@xxxxxxxxxx>
  • Date: Thu, 06 Mar 2008 00:43:02 +0100
  • Message-id: <1204760582.4686.45.camel@xxxxxxxxxxxxxx>
Hi,

So, I wanted to play a bit with the patch upstreaming project, and I
chose libwnck to start. I don't want to break things or something else,
so I'm sending the results here, to get some comments/help.

There are four patches:

+ libwnck-2.12.2-window-move-1.patch
This is... crazy. This adds a new API: wnck_window_move(), which is
available as wnck_window_set_geometry()... I'll assume this function
was not available when the patch got created.
Let's kill the patch, but we need to check if another package depends
on the new API.

+ libwnck-border_width-fix-2.patch
The patch is simply wrong. It tries to add the border width to the
window in some ways. Except that we're already handling them in
another way. Or I'm missing something...
Technically, it might help improve situation a bit for WMs that do
not respect the EWMH, but libwnck is not supposed to work really
well with those WM...
Original bug: https://bugzilla.novell.com/show_bug.cgi?id=178222

+ libwnck-opacity-2.patch
This adds some new API to set the opacity and add a menu item in the
window menu (which is used in the window list and in the compiz
decorator) to set the opacity. First part might go upstream once
the hint to set opacity is standardized and second part will not
go upstream, and I must say I think it's wrong to add this item.
I propose to simply remove the patch. But we might need to check
if another package uses the new API. Any hint on how to do so?

+ libwnck-realistic-layout.patch
Has been fixed upstream for quite some time now.

So, how to continue from here? :-)

Vincent

--
Les gens heureux ne sont pas press├ęs.


--
To unsubscribe, e-mail: opensuse-gnome+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-gnome+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups