On Montag, 2. September 2019 14:50:34 CEST Simon Lees wrote:
On 9/2/19 6:00 PM, Martin Wilck wrote:
On Sat, 2019-08-31 at 04:23 +0200, Aaron Puchert wrote:
Am 31.08.19 um 01:21 schrieb Stefan Brüns:
The devel package covers all parts of libqt5-qttools, but most packages only need the headers and libraries for compiling and linking. QDoc is only required to generate HTML help files from inline source documentation.
On second thought, it sounds very plausible that the -devel package should not depend on the -doc package.
That's the general point I was trying to make. IMO "Requires" for -devel packages should be used very conservatively. Only such packages should be pulled in that are positively, strictly necessary for *all* other packages that build against the given -devel package.
For others (your -doc package, for example), it would be little effort to add them as an additional build dependencies to those spec files that actually need them during build. It would also be easily detected, because those packages would fail to build (in the example: once the -devel -> -doc dependency was removed).
The benefit would be leaner build environments.
I guess you could make the argument that the primary use case for -devel packages could be to allow developers / users to write new applications using the library / toolkit etc and as such atleast recommending the development documentation makes sense. But I agree that a definition that leads to smaller build environments makes more sense. Although as a passing thought I wonder how much would fail / break, if we setup obs to ignore Recommends when setting up build roots. There are probably some evil autotools scripts out there doing autodetection that will silently drop features just because a header is no longer present. So I guess if someone did want to test it they'd have to do it in a separate staging with reproducible build checking enabled.
libqt5-qttools-doc is not a documentation package, but the package for the "qdoc" binary (a tool similar to doxygen). After some fighting, libqt5-qttools-devel no longer Requires libqt5-qttools or libqt5-qttools-doc. There were two packages which failed - qscintilla-qt5 (which needed just the plugin directory ownership) and libqt5-qtdoc (building the Qt5 API documentation, i.e. actually requiring libqt5-qttools-doc). The -devel package still recommends libqt5-qttools and libqt5-qttools-doc, but the OBS already ignores Recommends for building. Regards, Stefan -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org