Mailinglist Archive: opensuse-factory (138 mails)

< Previous Next >
Re: [opensuse-factory] NGINX Ingress Controller for Kubernetes - new packages
Thanks for everyone who commented and reviewed my requests!

Currently, the following requests are still in review. I would be very thankful
for the feedback or acceptance.

https://build.opensuse.org/request/show/620238
https://build.opensuse.org/request/show/620516
https://build.opensuse.org/request/show/620514
https://build.opensuse.org/request/show/620510
https://build.opensuse.org/request/show/620508
https://build.opensuse.org/request/show/620506
https://build.opensuse.org/request/show/620501
https://build.opensuse.org/request/show/620498
https://build.opensuse.org/request/show/620495

On 06/21/2018 03:06 PM, Martin Pluskal wrote:
On Tue, 2018-06-19 at 15:45 +0200, Michal Rostecki wrote:
Hi,


I would be very thankful for feedback and reviews.
Hi

As commented in sr [1]:
* In case package like nginx-module-devel-kit-source has to exist, it
would be nice to have it explained in form of i.e comment

Comments added in all requests which are still in review. I also added links to
this ML thread.

* It is strongly recommended to use macro for %configure, it is not
used:
+cd nginx
+./configure \
If it is not suitable, comment explaining this should be present
* "nginx-module-devel-kit.rpmlintrc" should be "nginx-module-devel-kit-
rpmlintrc" - I wonder why automatic checks did not catch this


Using %configure macro for nginx modules is impossible, because nginx's
configure script doesn't support some options that this macro is using (i.e.
--host). That's why the main nginx package doesn't use %configure macro as well.

Cheers,
Michal

< Previous Next >
This Thread
  • No further messages