Mailinglist Archive: opensuse-factory (498 mails)

< Previous Next >
Re: [opensuse-factory] GCC 6 as default compiler - your help is needed
On Wed, 25 May 2016, Bjoern Voigt wrote:

Is the GCC 6 option -Werror=misleading-indentation really helpful?

I saw this patch for Mozilla NSS:

The patch is long, but mostly changes indentation to make GCC 6 with
-Werror=misleading-indentation happy.

One example:
--- nss.orig/lib/dbm/src/hash.c
+++ nss/lib/dbm/src/hash.c
@@ -154,7 +154,7 @@ __hash_open(const char *file, int flags,
return NULL;
hashp->fp = NO_FILE;
- if(file)
+ if (file)
hashp->filename = strdup(file);


I believe this must be a spurious formatting change not required to
fix any -Wmisleading-indentation warning.


Richard Biener <rguenther@xxxxxxx>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB
21284 (AG Nuernberg)
To unsubscribe, e-mail: opensuse-factory+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-factory+owner@xxxxxxxxxxxx

< Previous Next >