On Wed, 04 Nov 2015 08:46:04 +0100, Andreas Schwab wrote:
Takashi Iwai
writes: Returning an integer or boolean value isn't necessarily wrong in many codes, and this can be such a case, I suppose (although I can't say exactly as I also haven't looked at the code).
It is never ok to return a boolean in a function that returns a pointer.
It is OK if it's cast. The returned value itself is same, just a different expression.
The more important question is why this is treated as a fatal error.
Because it's a fatal error.
What's the definition of "fatal"? If it's really a fatal error, why does it build for other than FACTORY? :) Don't get me wrong: I'm not against this action, it's for a good sake. But then it'd be better to suggest more understandable texts for novice packagers what to do for it. Takashi -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org