Quoting Cristian Rodríguez
El 05/05/13 15:39, Cristian Morales Vega escribió:
The problem is that some maintainers perhaps really don't know what the patch is about.
Do maintainers for example need explanation for this single line spec file change ?
mkdir -p m4
I hope everybody understands what mkdir does.
sure... but the question would immediately arise: why is this newly needed with automake 1.13 when it was not needed earlier... And a packager taking care of his .spec file will also want to know what symptoms can be observed, so we knows when he can remove this line again... Additionaly: "mkdir -p m4": really? -p? If "." does not exist, you also can not create it as a parent.. so it's just useless in this context anyway. And failing if m4 already exists would be a good thing here: it would give exactly the clear pointer that this automake targeted fixup in the .spec file is no longer needed. Dominique -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org