Thank you! That is extremely detailed and simple to follow advice. I will try to get this to build and be submitted. I currenly have a dns-resolver-with-options script on my servers that I used to replace dns-resolver and it makes my life a LOT easier. I am sure it will help others too. Tom On Sat 17 Mar 2012 06:05:45 PM EDT, Lars Müller wrote:
On Sat, Mar 17, 2012 at 01:19:49PM -0400, Tom Parker wrote:
How would I go about submitting a patch for the netconfig dns-resolver script that is part of the sysconfig package.
As Peter wrote this is easies to accomplish via the Open Build Service.¹
For the command line there is a subversion like command line tool named osc. It is available from the osc package which ist part of openSUSE oss repository.
With the help of it you branch the sysconfig package available from the Base:System project.
osc bco Base:System sysconfig
After pulling the package sources from the OBS you have a local copy of the package sources.
To these you apply your modification and add a short but well describing description to the package change log file (sysconfig.changes) by calling 'osc vc'
With 'osc build openSUSE_Factory x86_64' you try a local build. By this you see if your patch gets applied and at the end you also have an installable RPM. This you can use for testing for example.
Not it's time to call 'osc commit' which pushes your changes to your branched package at the openSUSE server. At https://build.openSUSE.org/ you can follow the build progress.
When everything works you file a submit request by calling 'osc sr' from your branches location back to the Base:System.
osc sr home:lmuelle:branches:Base:System sysconfig Base:System
would be the command line if I would have branched the sysconfig package.
As I like it to have a public reference of what changed I usually file a bug report and describe what's missing, broken, or going wrong. The resulting bug ID we're used to referece in the package change log in this form:
- Add netconfig sysconfig dns-resolver configuration option; (bnc#7623445).
This allows any of us in the community to follow the evolvement of a particular feature, fix, or other change. Even after quite soime time we'r able to check what had been the motivation, reason, the arguments to implement something in this particular way.
Following this line anyone is able to decide by its own if a change needs this amount of documentation or not. Said with other words, a simple typo does not require a bug report.
In your sysconfig case Marius <mt at suse dot com> is in charge of the component. He's is a nice and always very helpful guy. I'm sure he's open to such an enhancement as described by your mail.
And be welcome to the build fun!
Cheers,
Lars
¹ http://en.openSUSE.org/openSUSE:How_to_contribute_to_Factory -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org